Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not warn when selecting a text with comma #521

Merged
merged 2 commits into from
Nov 22, 2020

Conversation

veelenga
Copy link
Contributor

@veelenga veelenga commented Nov 21, 2020

When a text with comma is selected, the ember-cli-page-object produces a warning. Example:

// <fieldset>
//  <button>Lorem, Ipsum</button>
// </fieldset>

import { create, clickOnText } from 'ember-cli-page-object';

const page = create({
  clickOnButton: clickOnText('button')
});

page.clickOnButton('Lorem, Ipsum'); // Usage of comma separated selectors is deprecated in ember-cli-page-object

Fixes #518
Conflicts with #494

@veelenga veelenga force-pushed the fix/comma-separated-selectors-vs-text branch from c92a2b9 to f49085a Compare November 21, 2020 18:44
Copy link
Collaborator

@ro0gr ro0gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I'd like to avoid an extra method, by doing the check a bit earlier.

@veelenga veelenga requested a review from ro0gr November 22, 2020 14:07
Copy link
Collaborator

@ro0gr ro0gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks!

@ro0gr ro0gr merged commit 22afe08 into san650:master Nov 22, 2020
@ro0gr
Copy link
Collaborator

ro0gr commented Nov 22, 2020

just published your fix as 1.17.4

@veelenga veelenga deleted the fix/comma-separated-selectors-vs-text branch November 22, 2020 18:20
ro0gr pushed a commit to ro0gr/ember-cli-page-object that referenced this pull request Feb 7, 2021
@ro0gr ro0gr mentioned this pull request Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on text with comma produces a deprecation warning
2 participants