Do not warn when selecting a text with comma (san650#521)

ro0gr · Feb 7, 2021 · 56684da · 56684da
1 parent 680946b
commit 56684da
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 9 deletions.
diff --git a/addon-test-support/-private/helpers.js b/addon-test-support/-private/helpers.js
@@ -26,6 +26,15 @@ class Selector {
       scope = this.calculateScope(this.targetNode, this.targetScope);
     }
 
+    deprecate(
+      'Usage of comma separated selectors is deprecated in ember-cli-page-object',
+      `${scope} ${this.targetSelector}`.indexOf(',') === -1, {
+        id: 'ember-cli-page-object.comma-separated-selectors',
+        until: "2.0.0",
+        url: 'https://ember-cli-page-object.js.org/docs/v1.16.x/deprecations/#comma-separated-selectors',
+      }
+    );
+
     filters = this.calculateFilters(this.targetFilters);
 
     let selector = `${scope} ${this.targetSelector}${filters}`.trim();
@@ -36,14 +45,6 @@ class Selector {
       selector = ':first';
     }
 
-    deprecate(
-      'Usage of comma separated selectors is deprecated in ember-cli-page-object', selector.indexOf(',') === -1, {
-        id: 'ember-cli-page-object.comma-separated-selectors',
-        until: "2.0.0",
-        url: 'https://ember-cli-page-object.js.org/docs/v1.16.x/deprecations/#comma-separated-selectors',
-      }
-    );
-
     return selector;
   }
 

diff --git a/tests/integration/deprecations/comma-separated-selector-test.js b/tests/integration/deprecations/comma-separated-selector-test.js
@@ -2,7 +2,7 @@ import { module, test } from 'qunit';
 import { setupRenderingTest } from '../../helpers';
 import hbs from 'htmlbars-inline-precompile';
 
-import { create, text } from 'dummy/tests/page-object';
+import { create, text, clickOnText } from 'dummy/tests/page-object';
 
 import require from 'require';
 if (require.has('@ember/test-helpers')) {
@@ -69,5 +69,19 @@ if (require.has('@ember/test-helpers')) {
 
       assert.expectNoDeprecation();
     });
+
+    test('don\'t show deprecation when the selector contains text with comma', async function(assert) {
+      let page = create({
+        clickOnButton: clickOnText('button')
+      });
+
+      await render(hbs`<fieldset>
+        <button>Lorem, Ipsum</button>
+      </fieldset>`);
+
+      page.clickOnButton('Lorem, Ipsum');
+
+      assert.expectNoDeprecation();
+    });
   });
 }