Don't include # if there isn't any media fragment #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cjcolvar Do you want a test? |
|
Sure, I could add that. |
cjcolvar
force-pushed
the
cjcolvar-patch-1
branch
from
32522c6
to
d4b9e14
Compare
tpendragon
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your presenter implements
#media_fragmentand returns nil when there isn't a media fragment, you can end up with a canvas with a tailing#. A IIIF client that we're working with doesn't like this and it doesn't serve any purpose so this PR removes the#when no media fragment is present.