Don't include # if there isn't any media fragment

samvera · Mar 12, 2019 · d4b9e14 · d4b9e14
1 parent 18d0690
commit d4b9e14
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/iiif_manifest/v3/manifest_builder/canvas_builder.rb b/lib/iiif_manifest/v3/manifest_builder/canvas_builder.rb
@@ -30,7 +30,7 @@ def canvas
 
         def path
           path = "#{parent.manifest_url}/canvas/#{record.id}"
-          path << "##{record.media_fragment}" if record.respond_to?(:media_fragment)
+          path << "##{record.media_fragment}" if record.respond_to?(:media_fragment) && record.media_fragment.present?
           path
         end
 

diff --git a/spec/lib/iiif_manifest/v3/manifest_builder/canvas_builder_spec.rb b/spec/lib/iiif_manifest/v3/manifest_builder/canvas_builder_spec.rb
@@ -33,6 +33,15 @@
       it 'returns a canvas url' do
         expect(builder.path).to eq 'http://test.host/books/book-77/manifest/canvas/test-22#xywh=160,120,320,240'
       end
+
+      context 'and is blank' do
+        before do
+          allow(record).to receive(:media_fragment).and_return(nil)
+        end
+        it 'returns a canvas url' do
+          expect(builder.path).to eq 'http://test.host/books/book-77/manifest/canvas/test-22'
+        end
+      end
     end
   end
 end