-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the CircleCI configuration to support nightly builds #1478
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
@@ -1,21 +1,21 @@ | ||||||||||
version: 2.1 | ||||||||||
orbs: | ||||||||||
samvera: samvera/circleci-orb@0 | ||||||||||
samvera: samvera/circleci-orb@1.0 | ||||||||||
jobs: | ||||||||||
bundle_lint_test: | ||||||||||
parameters: | ||||||||||
ruby_version: | ||||||||||
type: string | ||||||||||
bundler_version: | ||||||||||
type: string | ||||||||||
default: 2.0.1 | ||||||||||
default: 2.3.11 | ||||||||||
rails_version: | ||||||||||
type: string | ||||||||||
solr_config_path: | ||||||||||
type: string | ||||||||||
default: lib/generators/active_fedora/config/solr/templates/solr/conf | ||||||||||
executor: | ||||||||||
name: 'samvera/ruby_fcrepo_solr' | ||||||||||
name: 'samvera/ruby_fcrepo_solr_redis_postgres' | ||||||||||
ruby_version: << parameters.ruby_version >> | ||||||||||
environment: | ||||||||||
RAILS_VERSION: << parameters.rails_version >> | ||||||||||
|
@@ -31,7 +31,7 @@ jobs: | |||||||||
echo "$(git branch --all --list master */master)" | ||||||||||
fi | ||||||||||
[[ -z "$(git branch --all --list master */master)" ]] | ||||||||||
|
||||||||||
- samvera/bundle_for_gem: | ||||||||||
ruby_version: << parameters.ruby_version >> | ||||||||||
bundler_version: << parameters.bundler_version >> | ||||||||||
|
@@ -47,31 +47,79 @@ jobs: | |||||||||
workflows: | ||||||||||
ci: | ||||||||||
jobs: | ||||||||||
# Ruby 2.7 releases | ||||||||||
- bundle_lint_test: | ||||||||||
name: ruby2-7_rails6-0 | ||||||||||
ruby_version: 2.7.5 | ||||||||||
rails_version: 6.0.4.7 | ||||||||||
- bundle_lint_test: | ||||||||||
name: ruby2-7_rails5-2 | ||||||||||
ruby_version: 2.7.0 | ||||||||||
ruby_version: 2.7.5 | ||||||||||
rails_version: 5.2.4 | ||||||||||
Comment on lines
+57
to
58
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should these be updated to the latest versions?
Suggested change
|
||||||||||
# Ruby 2.6 releases | ||||||||||
- bundle_lint_test: | ||||||||||
name: ruby2-6_rails6-0 | ||||||||||
ruby_version: 2.6.9 | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like there is also a ruby |
||||||||||
rails_version: 6.0.4.7 | ||||||||||
- bundle_lint_test: | ||||||||||
name: ruby2-6_rails5-2 | ||||||||||
ruby_version: 2.6.5 | ||||||||||
ruby_version: 2.6.9 | ||||||||||
rails_version: 5.2.4 | ||||||||||
# Ruby 2.5 releases | ||||||||||
- bundle_lint_test: | ||||||||||
name: ruby2-5_rails6.0 | ||||||||||
ruby_version: 2.5.9 | ||||||||||
rails_version: 6.0.4.7 | ||||||||||
- bundle_lint_test: | ||||||||||
name: ruby2-5_rails5-2 | ||||||||||
ruby_version: 2.5.7 | ||||||||||
ruby_version: 2.5.9 | ||||||||||
rails_version: 5.2.4 | ||||||||||
|
||||||||||
nightly: | ||||||||||
triggers: | ||||||||||
- schedule: | ||||||||||
cron: "0 0 * * *" | ||||||||||
filters: | ||||||||||
branches: | ||||||||||
only: | ||||||||||
- main | ||||||||||
jobs: | ||||||||||
# Ruby 2.7 releases | ||||||||||
- bundle_lint_test: | ||||||||||
name: ruby2-4_rails5-2 | ||||||||||
ruby_version: 2.4.9 | ||||||||||
rails_version: 5.2.4 | ||||||||||
name: ruby2-7_rails6-1 | ||||||||||
ruby_version: 2.7.5 | ||||||||||
rails_version: 6.1.5 | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not seeing rails 6.1 being tested in the commit-triggered build. How about adding it to the on-commit build matrix? If it doesn't work then I would think it should be removed from both on-commit and nightly builds until it can be resolved. |
||||||||||
- bundle_lint_test: | ||||||||||
name: ruby2-7_rails6-0 | ||||||||||
ruby_version: 2.7.0 | ||||||||||
rails_version: 6.0.2 | ||||||||||
ruby_version: 2.7.5 | ||||||||||
rails_version: 6.0.4.7 | ||||||||||
- bundle_lint_test: | ||||||||||
name: ruby2-7_rails5-2 | ||||||||||
ruby_version: 2.7.5 | ||||||||||
rails_version: 5.2.4 | ||||||||||
# Ruby 2.6 releases | ||||||||||
- bundle_lint_test: | ||||||||||
name: ruby2-6_rails6-1 | ||||||||||
ruby_version: 2.6.9 | ||||||||||
rails_version: 6.1.5 | ||||||||||
- bundle_lint_test: | ||||||||||
name: ruby2-6_rails6-0 | ||||||||||
ruby_version: 2.6.5 | ||||||||||
rails_version: 6.0.2 | ||||||||||
ruby_version: 2.6.9 | ||||||||||
rails_version: 6.0.4.7 | ||||||||||
- bundle_lint_test: | ||||||||||
name: ruby2-6_rails5-2 | ||||||||||
ruby_version: 2.6.9 | ||||||||||
rails_version: 5.2.4 | ||||||||||
# Ruby 2.5 releases | ||||||||||
- bundle_lint_test: | ||||||||||
name: ruby2-5_rails6-1 | ||||||||||
ruby_version: 2.5.9 | ||||||||||
rails_version: 6.1.5 | ||||||||||
- bundle_lint_test: | ||||||||||
name: ruby2-5_rails6.0 | ||||||||||
ruby_version: 2.5.7 | ||||||||||
rails_version: 6.0.2 | ||||||||||
ruby_version: 2.5.9 | ||||||||||
rails_version: 6.0.4.7 | ||||||||||
- bundle_lint_test: | ||||||||||
name: ruby2-5_rails5-2 | ||||||||||
ruby_version: 2.5.9 | ||||||||||
rails_version: 5.2.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this build need redis and postgres? I'm curious why you made this change.