-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the CircleCI configuration to support nightly builds #1478
Conversation
…ng the configuration to test against Ruby 2.7, 2.6, and 2.5 releases; Updating the configuration to test against Rails 6.0.4.7, 5.2.4; Setting the default Rails release to be used as the latest 6.0 release
rails_version: | ||
type: string | ||
solr_config_path: | ||
type: string | ||
default: lib/generators/active_fedora/config/solr/templates/solr/conf | ||
executor: | ||
name: 'samvera/ruby_fcrepo_solr' | ||
name: 'samvera/ruby_fcrepo_solr_redis_postgres' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this build need redis and postgres? I'm curious why you made this change.
ruby_version: 2.7.5 | ||
rails_version: 5.2.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these be updated to the latest versions?
ruby_version: 2.7.5 | |
rails_version: 5.2.4 | |
ruby_version: 2.7.6 | |
rails_version: 5.2.7 |
# Ruby 2.6 releases | ||
- bundle_lint_test: | ||
name: ruby2-6_rails6-0 | ||
ruby_version: 2.6.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there is also a ruby 2.6.10
now.
rails_version: 5.2.4 | ||
name: ruby2-7_rails6-1 | ||
ruby_version: 2.7.5 | ||
rails_version: 6.1.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing rails 6.1 being tested in the commit-triggered build. How about adding it to the on-commit build matrix? If it doesn't work then I would think it should be removed from both on-commit and nightly builds until it can be resolved.
Resolved in #1483 |
Resolves #1477 and addresses the following: