Updating the CircleCI configuration to support nightly builds #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the configuration to test against Ruby 2.7, 2.6, and 2.5 releases; Updating the configuration to test against Rails 6.0.4.7, 5.2.4; Setting the default Rails release to be used as the latest 6.0 release
18 tasks
cjcolvar
reviewed
Apr 18, 2022
| rails_version: | ||
| type: string | ||
| solr_config_path: | ||
| type: string | ||
| default: lib/generators/active_fedora/config/solr/templates/solr/conf | ||
| executor: | ||
| name: 'samvera/ruby_fcrepo_solr' | ||
| name: 'samvera/ruby_fcrepo_solr_redis_postgres' |
There was a problem hiding this comment.
Does this build need redis and postgres? I'm curious why you made this change.
Comment on lines
+57
to
58
| ruby_version: 2.7.5 | ||
| rails_version: 5.2.4 |
There was a problem hiding this comment.
Should these be updated to the latest versions?
Suggested change
| ruby_version: 2.7.5 | |
| rails_version: 5.2.4 | |
| ruby_version: 2.7.6 | |
| rails_version: 5.2.7 |
| # Ruby 2.6 releases | ||
| - bundle_lint_test: | ||
| name: ruby2-6_rails6-0 | ||
| ruby_version: 2.6.9 |
There was a problem hiding this comment.
Looks like there is also a ruby 2.6.10 now.
| rails_version: 5.2.4 | ||
| name: ruby2-7_rails6-1 | ||
| ruby_version: 2.7.5 | ||
| rails_version: 6.1.5 |
There was a problem hiding this comment.
I'm not seeing rails 6.1 being tested in the commit-triggered build. How about adding it to the on-commit build matrix? If it doesn't work then I would think it should be removed from both on-commit and nightly builds until it can be resolved.
|
Resolved in #1483 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1477 and addresses the following: