Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pip.list parsing of local packages #63354

Merged
merged 7 commits into from
Feb 1, 2023
Merged

Fix pip.list parsing of local packages #63354

merged 7 commits into from
Feb 1, 2023

Conversation

nicholasmhughes
Copy link
Collaborator

What does this PR do?

See issues for details.

What issues does this PR fix or reference?

Fixes: #58202
Fixes: #60557

Previous Behavior

The previous functionality parsed pip freeze output line by line as strings.

New Behavior

The new functionality uses pip list with JSON output, which allows Salt to parse as a data structure which already has components such as name and version separated.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@nicholasmhughes nicholasmhughes requested a review from a team as a code owner December 21, 2022 15:45
@nicholasmhughes nicholasmhughes requested review from MKLeb and removed request for a team December 21, 2022 15:45
@nicholasmhughes
Copy link
Collaborator Author

re-run pr-arch-lts-x86_64-py3-pytest

@nicholasmhughes
Copy link
Collaborator Author

re-run pr-windows-2019-x64-py3-pytest

@nicholasmhughes
Copy link
Collaborator Author

re-run pr-ubuntu-2004-arm64-py3-pytest

s0undt3ch
s0undt3ch suggested changes Dec 25, 2022
View reviewed changes
Copy link
Collaborator

@s0undt3ch s0undt3ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And, if we drop support for older pip, we don't really need a separate list function(list_freeze_parse) doe we?

Anyway, let see what the rest of the team thinks about dropping really old pip versions.

salt/modules/pip.py Show resolved Hide resolved
@nicholasmhughes nicholasmhughes added the Sulfur v3006.0 release code name and version label Jan 6, 2023
@Ch3LL
Copy link
Contributor

Ch3LL commented Jan 9, 2023

@s0undt3ch can you re-review please

@nicholasmhughes nicholasmhughes mentioned this pull request Jan 20, 2023
Open
@nicholasmhughes
Copy link
Collaborator Author

re-run pr-photon-3-x86_64-py3-pytest

@garethgreenaway garethgreenaway merged commit 2515b31 into saltstack:master Feb 1, 2023
@nicholasmhughes nicholasmhughes deleted the fix-pip.list-local-packages branch February 2, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynew waynew waynew left review comments

@garethgreenaway garethgreenaway garethgreenaway approved these changes

@Ch3LL Ch3LL Ch3LL approved these changes

@twangboy twangboy twangboy approved these changes

@MKLeb MKLeb Awaiting requested review from MKLeb MKLeb was automatically assigned from saltstack/team-core

@s0undt3ch s0undt3ch Awaiting requested review from s0undt3ch

Assignees
No one assigned
Labels
Sulfur v3006.0 release code name and version
Projects
None yet
Milestone
No milestone
6 participants
@nicholasmhughes @Ch3LL @waynew @s0undt3ch @garethgreenaway @twangboy