Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Regression: pip.installed does not pass env_vars when calling pip.list to check if package is already installed #60557

Closed
redbaron4 opened this issue Jul 16, 2021 · 1 comment · Fixed by #63354
Labels
Bug broken, incorrect, or confusing behavior
Milestone

Comments

@redbaron4
Copy link
Contributor

Description
This is a regression of #46127 and was introduced a few months after the original fix merged

See that bug for more details about how to reproduce the issue

Additional context

This commit made a change to cache the installed list using pip.list to speed up pip execution. However, the call to pip list does not pass env_vars (see 3003.1 code here) and hence the bug has reappeared.

pip_list = __salt__["pip.list"](bin_env=bin_env, user=user, cwd=cwd)

Fix is trivial by passing env_vars=env_vars to this function.

@redbaron4 redbaron4 added Bug broken, incorrect, or confusing behavior needs-triage labels Jul 16, 2021
@smokeytheblair smokeytheblair added this to the Approved milestone Aug 3, 2021
@smokeytheblair
Copy link

When this gets addressed, please note that **kwargs is also not being passed. Will want to confirm if that is also an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants