Don't remove one directory level from slspath #55433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_49481 [master] Porting saltstack#49481 to master
…_51287 [master] Porting saltstack#51287 to master
…_50953 [master] Porting saltstack#50953 to master
…analytics remove google-analytics
…orting Enable Coverage Reporting on PRs
Master webconfig settings
Try to use the same version matching python binary
…en_image_update update to master branch of golden images for debian 10
…_52562 [master] Porting saltstack#52562 to master
…_52589 [master] Porting saltstack#52589 to master
…ged-8 [PyTest #8] Flaky decorator fixes
…ged-9 [PyTest #9] Py2/Py3 Unicode Fixes
…ged-11 [PyTest #11] Salt's test suite should not worry about coverage anymore.
…ged-12 [PyTest #12] Test scenario only manifests itself with the ZMQ transport
…ng_on_ipv6 fix network ping test on windows with ipv6
Bump SaltPyLint requirement
…abled Doc fix in pkgrepo state
…with_xz compress docs with xz to save more space
Less flaky retry tests
Lint fixes to master & Lint pre-commit hook fixes
doc: escape special characters on linux for cmd.run
Adds the possibility to also use downloadonly in kwargs
Update win_path.py
…y-installed Make aptpkg.info return only installed packages
ghost
requested a review
from 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks the tpldir jinja context variable for the cases where there
is an SLS path in the format
X.X(e.g.foo.foo,bar.bar, etc.).It also conflicts with the stated documentation for this parameter in
doc/rev/states/vars.rst, which states that this variable should be thepath to the SLS target. In reality this is passed in via
context['sls']and already has the correct path.If I were to wager a guess, I would say that it's likely that the way
context['sls']is formulated has changed at some point since these twolines were added in 2014, making these two lines unnecessary.
What does this PR do?
What issues does this PR fix or reference?
Previous Behavior
Remove this section if not relevant
New Behavior
Remove this section if not relevant
Tests written?
[NOTICE] Bug fixes or features added to Salt require tests.
Please review the test documentation for details on how to implement tests into Salt's test suite.
Yes/No
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.