Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Porting #49481 to master #54532

Merged
merged 4 commits into from
Oct 31, 2019
Merged

[master] Porting #49481 to master #54532

merged 4 commits into from
Oct 31, 2019

Conversation

garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented Sep 18, 2019 •
edited
Loading

Porting #49481 to master

@garethgreenaway garethgreenaway requested a review from a team as a code owner September 18, 2019 23:30
@ghost ghost requested a review from twangboy September 18, 2019 23:30
twangboy
twangboy approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@twangboy twangboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if you could do it before the grains were populated...

@garethgreenaway
Copy link
Contributor Author

re-run full all

@garethgreenaway garethgreenaway changed the title [2019.2.1] Porting #49481 to 2019.2.1 [master] Porting #49481 to master Sep 24, 2019
@garethgreenaway garethgreenaway changed the base branch from 2019.2.1 to master September 24, 2019 23:01
@dwoz dwoz merged commit 52c6e12 into saltstack:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynew waynew waynew approved these changes

@s0undt3ch s0undt3ch s0undt3ch approved these changes

@dwoz dwoz dwoz approved these changes

@twangboy twangboy twangboy approved these changes

Assignees
No one assigned
Labels
master-port
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@garethgreenaway @waynew @s0undt3ch @dwoz @twangboy