Fix master_tops configuration rendering #313
Conversation
|
@0xf10e could you take a look please otherwise I merge this. |
|
Sorry, @aboe76, missed your request for review there.
|
| {%- for parameter in cfg_master['master_tops'][master] %} | ||
| {{ parameter }}: {{ cfg_master['master_tops'][master][parameter] }} | ||
| {%- endfor -%} | ||
| {%- endif -%} | ||
| {%- elif cfg_master['master_tops'][master] is string %} |
There was a problem hiding this comment.
No need for a separate test for string. Just let the else handle all the scalar types.
There was a problem hiding this comment.
@0xf10e , I also though like this initially, but it wasn't correct, because string is iterable, so the behaviour was not the expect one.
I think that the correct configuration can be created only if the string is treated before other iterable items.
|
merging this, tested with without the string match, and indeed it causes weird behaviors. |
When you add a custom master top to the saltmaster configuration the master.sls state will fail if the config looks like:
This happens because it wil not treat the situation when you have a boolean as a value for the customtop.
See also:
https://docs.saltstack.com/en/latest/topics/master_tops/index.html
My change consists in checking for all possible values and apply the state accordingly.