Hack to make rendering work on CentOS 6

[0xf10e]

!! Not tested with an actual !!
!! configured ext_pillar yet !!

• jinja on RHEL/CentOS 6 has no 'mapping'
  test (see salt-formula issue [CentOS 6] mapping test not supported, master config cannot be generated #193)
• {% do ... %} allows no assignment, only
  function calls
• of course, type(foo) is dict doesn't
  work because it's no jinja test
• maybe .isinstance() would be nicer/more
  reliable

[0xf10e]

Looks like this patch isn't enough to fix #193:

/srv/salt/pillar.git:1711% sudo salt centos6minion state.sls salt.master
centos6minion:
    Data failed to compile:
----------
    Rendering SLS 'base:salt.master' failed: Jinja syntax error: no test named 'mapping'
/var/cache/salt/minion/files/base/salt/map.jinja(8):
---
[...]

{%- macro deep_merge(a, b) %}
{%-     for k,v in b.iteritems() %}
{%-         if v is string or v is number %}
{%-             do a.update({ k: v }) %}
{%-         elif v is not mapping %}    <======================
{%-             if a[k] is not defined %}
{%-                 do a.update({ k: v }) %}
{%-             elif a[k] is iterable and a[k] is not mapping and a[k] is not string %}
{%-                 do a.update({ k: v|list + a[k]|list}) %}
{%-             else %}
[...]
---
ERROR: Minions returned with non-zero exit code

😒

[0xf10e]

@blast-hardcheese @mchugh19 @gravyboat
I only tested with an almost empty pillar[salt]* but e86e6fc makes the states salt.master and salt.minion render and run on CentOS 6 .

*)

/srv/salt/formulas/salt-formula.git:1818% sudo salt centos6minion pillar.items
centos6minion:
    ----------
    salt:
        ----------
        minion:
            ----------
            master:
                192.168.178.20

[gravyboat]

Definitely hacky but it looks okay to me. I can't merge any more so someone else will have to do it.

[0xf10e]

I don't want to merge my own PR, maybe @ek9 , @aboe76 or @iggy?