Set explicit utf-8 encoding #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the encoding on the XML builder explictly to utf-8. While it may be useful to be able to pass an encoding for the XML, UTF-8 will be correct in most cases, and a fixed utf-8 encoding is preferable to setting no encoding at all.
|
Great, thank you! |
Closed
rogercampos
pushed a commit
to factorialco/sepa_king
that referenced
this pull request
Feb 16, 2023
Set the encoding on the XML builder explictly to utf-8. While it may be useful to be able to pass an encoding for the XML, UTF-8 will be correct in most cases, and a fixed utf-8 encoding is preferable to setting no encoding at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the encoding on the XML builder explictly to utf-8.
While it may be useful to be able to pass an encoding for the XML,
UTF-8 will be correct in most cases, and a fixed utf-8 encoding
is preferable to setting no encoding at all.
This should fix #85 and #87