-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to install v3.0.0 on node 6.14.0 #140
Comments
Try |
Yes with that flag I'm able to bypass the issue and install tough-cookie, but does that doesn't solve the actual problem. I think tough-cookie should either depend on an older version of ip-regex, or enforce node >=8 as well. |
Caused by a transitive dependency of `ip-regex#3.0.0` requiring node 8, see salesforce/tough-cookie#140. Can be removed again once salesforce/tough-cookie#141 is merged and released!
I agree with @thijskramer. Either use |
To be fair |
@jrjohnson it explicitly only dropped support for Node 4 and below though... (see 16ba441) |
I'm sorry that I didn't get this resolved sooner. This is pretty much all on me. This fix has been published as version 3.0.1. To be totally honest with you, I'm stretched incredibly thin for time as I'm trying to get my business started up. Me, and the folks from Salesforce meet on a monthly basis to discuss bugs and pull requests. I then spend that day and maybe the day after, tops, working on tough-cookie before returning to my other tasks. This is more frequently than change happened historically, but clearly isn't reactive enough. I could be doing fixes like this if I had additional bandwidth, but I don't; I'm having a hard time justifying working for free versus working to get to the point where I'm not living off of savings. If you know someone who'd like to help co-maintain tough-cookie, please send them our way; we'd love the help. |
Since today I'm unable to install tough-cookie on node v6.14.0, because I'm getting the following error:
error ip-regex@3.0.0: The engine "node" is incompatible with this module. Expected version ">=8". Got "6.14.0"
I suspect that the introduction of
ip-regex
in PR #138 (and especially this commit) causes that, becauseip-regex ^3.0.0
needs at least node v8.The text was updated successfully, but these errors were encountered: