Use ip-regex instead of net.isIP. Fix #125

salesforce · Dec 31, 2018 · eff9118 · eff9118 · gkwang · Jan 17, 2019
1 parent 7c1fdf1
commit eff9118
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/cookie.js b/lib/cookie.js
@@ -29,9 +29,9 @@
  * POSSIBILITY OF SUCH DAMAGE.
  */
 'use strict';
-var net = require('net');
 var urlParse = require('url').parse;
 var util = require('util');
+var ipRegex = require('ip-regex')({ exact: true });
 var pubsuffix = require('./pubsuffix-psl');
 var Store = require('./store').Store;
 var MemoryCookieStore = require('./memstore').MemoryCookieStore;
@@ -320,7 +320,7 @@ function domainMatch(str, domStr, canonicalize) {
   /* "All of the following [three] conditions hold:" (order adjusted from the RFC) */
 
   /* "* The string is a host name (i.e., not an IP address)." */
-  if (net.isIP(str)) {
+  if (ipRegex.test(str)) {
     return false;
   }
 

diff --git a/package.json b/package.json
@@ -72,6 +72,7 @@
     "vows": "^0.8.2"
   },
   "dependencies": {
+    "ip-regex": "^3.0.0",
     "psl": "^1.1.28",
     "punycode": "^2.1.1"
   }