Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): revert compiler merge #282

Merged
merged 1 commit into from
May 7, 2018

Conversation

apapko
Copy link
Collaborator

@apapko apapko commented May 7, 2018

Reverts #256

@apapko apapko requested review from pmdartus and byao May 7, 2018 18:31
@apapko apapko changed the title wip: REVERT compiler merge wip: revert compiler merge May 7, 2018
@apapko apapko changed the title wip: revert compiler merge wip(compiler): revert compiler merge May 7, 2018
@apapko apapko changed the title wip(compiler): revert compiler merge fix(compiler): revert compiler merge May 7, 2018
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 950d196 | Target commit: efd16f6

lwc-engine-benchmark

table-append-1k metric base(950d196) target(efd16f6) trend
benchmark-table/append/1k duration 151.30 (± 6.60 ms) 151.70 (± 4.70 ms) -0.26% 👌
table-clear-1k metric base(950d196) target(efd16f6) trend
benchmark-table/clear/1k duration 11.90 (± 0.70 ms) 11.70 (± 0.50 ms) 1.68% 👌
table-create-10k metric base(950d196) target(efd16f6) trend
benchmark-table/create/10k duration 860.20 (± 6.20 ms) 872.90 (± 10.10 ms) -1.48% 👎
table-create-1k metric base(950d196) target(efd16f6) trend
benchmark-table/create/1k duration 102.80 (± 1.90 ms) 101.30 (± 1.90 ms) 1.46% 👍
table-update-10th-1k metric base(950d196) target(efd16f6) trend
benchmark-table/update-10th/1k duration 88.70 (± 5.30 ms) 87.80 (± 3.90 ms) 1.01% 👌
tablecmp-append-1k metric base(950d196) target(efd16f6) trend
benchmark-table-component/append/1k duration 244.90 (± 6.10 ms) 252.20 (± 8.50 ms) -2.98% 👎
tablecmp-clear-1k metric base(950d196) target(efd16f6) trend
benchmark-table/clear/1k duration 33.15 (± 1.70 ms) 33.10 (± 1.65 ms) 0.15% 👌
tablecmp-create-10k metric base(950d196) target(efd16f6) trend
benchmark-table-component/create/10k duration 1712.70 (± 6.50 ms) 1700.90 (± 13.00 ms) 0.69% 👌
tablecmp-create-1k metric base(950d196) target(efd16f6) trend
benchmark-table-component/create/1k duration 196.70 (± 5.10 ms) 195.80 (± 3.40 ms) 0.46% 👌
tablecmp-update-10th-1k metric base(950d196) target(efd16f6) trend
benchmark-table-component/update-10th/1k duration 74.90 (± 4.30 ms) 75.50 (± 4.10 ms) -0.80% 👌

@apapko apapko merged commit 8bf1dd5 into master May 7, 2018
@pmdartus pmdartus deleted the revert-256-apapko/raptor-on-platform-compiler branch June 18, 2018 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants