feat(compiler): introduce compile/transform/bundle diagnostics #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wip: module import locations * wip: move import locations into metadata * wip: rename import locations * wip: use common location class in import locations * wip: change regex and token retrieval
Benchmark comparisonBase commit:
|
Benchmark comparisonBase commit:
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
* feat(compiler): use real compiler version during build
Benchmark resultsBase commit: lwc-engine-benchmark
|
pmdartus
requested changes
Apr 30, 2018
package.json
Outdated
| ] | ||
| ], | ||
| "dependencies": { | ||
| "source-map": "^0.7.2" |
packages/lwc-compiler/package.json
Outdated
| "@types/babel-core": "^6.25.3", | ||
| "@types/chokidar": "^1.7.5", | ||
| "magic-string": "^0.22.4", | ||
| "source-map": "^0.7.2", |
packages/lwc-compiler/package.json
Outdated
| @@ -29,6 +30,10 @@ | |||
| "rollup-plugin-replace": "^2.0.0" | |||
| }, | |||
| "devDependencies": { | |||
| "@types/babel-core": "^6.25.3", | |||
| "@types/chokidar": "^1.7.5", | |||
| "magic-string": "^0.22.4", | |||
packages/lwc-compiler/package.json
Outdated
| @@ -29,6 +30,10 @@ | |||
| "rollup-plugin-replace": "^2.0.0" | |||
| }, | |||
| "devDependencies": { | |||
| "@types/babel-core": "^6.25.3", | |||
| "@types/chokidar": "^1.7.5", | |||
| const { version } = require("../package.json"); | ||
|
|
||
| async function updateVersion(version) { | ||
| const inputPath = (outputPath = path.resolve("dist/commonjs/index.js")); |
There was a problem hiding this comment.
No single line assignment. This will not work if this file is in strict mode.
| // split result: ["'x-bar', 'x-foo'"] | ||
| const imports = rawImports.split(/,\s*/) || []; | ||
|
|
||
| imports.forEach(moduleImport => { |
There was a problem hiding this comment.
A good old Array.prototype.map would do the trick here instead of a Array.prototype.forEach. This way the callback can become pure.
packages/lwc-compiler/src/options.ts
Outdated
| files: BundleFiles; | ||
| outputConfig?: OutputConfig; | ||
|
|
||
| // TODO: below must be removed after lwc-compiler consumers change |
| }); | ||
| const result = babel.transform(code, config); | ||
|
|
||
| if (!result || !result.code) { |
There was a problem hiding this comment.
When is it the case?
I would like to have a more explicit error when babel doesn't return any code.
| src: string, | ||
| filename: string, | ||
| { outputConfig }: NormalizedCompilerOptions, | ||
| metadataCollector?: MetadataCollector, |
| src: string, | ||
| filename: string, | ||
| options: NormalizedCompilerOptions, | ||
| metadataCollector?: MetadataCollector |
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
pmdartus
reviewed
May 4, 2018
|
|
||
| describe("compiler options", () => { | ||
| it("should validate presence of options", async () => { | ||
| expect.assertions(1); |
There was a problem hiding this comment.
Remove the expect.assertion(1). Not needed anymore.
Benchmark resultsBase commit: lwc-engine-benchmark
|
pmdartus
approved these changes
May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR includes several enhancements to the open source compiler to allow for source code diagnostics and cleaner integration with platform compiler. The open source compiler will be consumed by platform-compiler for transformation and bundling invocation. Furthermore, as part of the effort to minimize compiler maintenance and code/feature duplication, platform-compiler, which in-itself consumes open source compiler, will be now used by both Aura open source and core in the form of a jar ( maven dependency ).
Some details on the changes:
Few remaining TODOS:
Does this PR introduce a breaking change?
Compiler interface has changed. Aura will now be using platform compiler instead - thus invocation API must be change in Aura to satisfy platform compiler interface - tracked separately.