add support for softlinked workspace files #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plaird
commented
Oct 9, 2020
| @@ -55,6 +55,11 @@ public void initializeDefaultPreferences() { | |||
| IPreferenceStore store = BazelPluginActivator.getInstance().getPreferenceStore(); | |||
| Properties globalPrefs = loadGlobalPreferences(); | |||
|
|
|||
| // TODO Instead of doing this manual mapping of global prefs into prefs, which requires an entry | |||
There was a problem hiding this comment.
this gets cleaned up in the next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a worrisome solution for #164. I am not totally comfortable with the solution, but the system Open dialog's behavior does not seem to be configurable. If the WORKSPACE file is a softlink, the Open dialog resolves the soft link to the canonical path. So to support this use case we need to detect that we are in a non-root directory of the Bazel workspace. This could get nasty as Bazel supports nested workspaces, but the solution seems to be ok since it makes sure the found WORKSPACE soft link is pointing to the canonical file identified by the user.
I also added a pref to disable this feature, just in case there is trouble with it. A follow on PR will clean up the prefs stuff, it is a little rough.