Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Bazel workspaces that have a soft linked WORKSPACE file #164

Closed
asmittal opened this issue Sep 22, 2020 · 4 comments
Closed

Support Bazel workspaces that have a soft linked WORKSPACE file #164

asmittal opened this issue Sep 22, 2020 · 4 comments
Assignees
Labels
user feature New feature or request

Comments

@asmittal
Copy link

asmittal commented Sep 22, 2020

In our code setup, Workspace file in the git root is actually soft link to the actual file, which is nested bit deeper.
On Importing the softlink workspace file, window to select the projects/modules is not shown. It imports the workspace file, showing empty workspace project.
OS: Mac latest
Eclipse : Sept 2020
Plugin: Latest

@plaird
Copy link
Contributor

plaird commented Sep 28, 2020

@asmittal what would really help with this feature request is an explanation of why your repo has the WORKSPACE file soft linked from a different directory. Also, does the soft linked WORKSPACE have load() statements for other .bzl files that are also soft linked?

@plaird plaird added the user feature New feature or request label Sep 28, 2020
@plaird plaird changed the title If workspace file is softlink, import doesnt work. Support Bazel workspaces that have a soft linked WORKSPACE file Sep 28, 2020
@plaird
Copy link
Contributor

plaird commented Oct 9, 2020

@asmittal this feature went in as of PR #175 and it will appear in a release shortly. Please try it out when you can. Because of the way the system File Open dialog works, the solution wasn't nice. So I can't guarantee this feature will stay in forever if it causes problems.

I have asked a few times, can you please explain why you are soft linking your WORKSPACE file? I am trying to understand the reason as I have not seen that before. That will help justifying keeping this feature. Thanks!

@plaird plaird closed this as completed Oct 9, 2020
@plaird plaird self-assigned this Oct 9, 2020
@plaird
Copy link
Contributor

plaird commented Oct 9, 2020

@asmittal BEF 1.2.3 has now been released with your feature.

@asmittal
Copy link
Author

asmittal commented Oct 9, 2020

@asmittal this feature went in as of PR #175 and it will appear in a release shortly. Please try it out when you can. Because of the way the system File Open dialog works, the solution wasn't nice. So I can't guarantee this feature will stay in forever if it causes problems.

I have asked a few times, can you please explain why you are soft linking your WORKSPACE file? I am trying to understand the reason as I have not seen that before. That will help justifying keeping this feature. Thanks!

Really sorry, for responding late on this. I tried to check with our build team for having this complicated structure. But even after days haven't received any response.
In case I do hear from them in coming days, I will let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants