-
Notifications
You must be signed in to change notification settings - Fork 673
Conversation
Is everything fine with CircleCI config? This PR fails at both (build, cypress/run) steps with |
@przlada thank you a lot for this PR! It looks great. CircleCI failed because we are not running it for forked repos. I'll run tests myself. |
👌💥⭐️ |
I added transifex resource for this project, so it's now really translatable :) |
Hey @przlada, thanks a lot for your contribution! If you're willing to help even more, I think next week we should be able to provide more detailed issues with descriptions of what needs to be done. We already have designs of the language switcher which we'd share with you as well. We need to wait for @krzysztofwolski to return from holiday as he's in charge of the project :) |
That's great, thanks @dominik-zeglen 👍 I added my test Polish translation to Transifex and made PR with it #786 |
@maarcingebala Yes I'm willing to help 😊 I will patiently wait for @krzysztofwolski. What's the best way to discuss the details? Here on Github or using some different channels? |
@przlada I'm back! On Thursday I'll have github issues for you with designs. Personally I'm fan of async communication on GH, but if there will be any questions I'm open for Hangouts call |
I want to merge this change because... it adds
react-intl
integration. Basing on the great work of @Wael-Mohamed PR (#731) I made another clean attempt to localize storefront. I fully agree with @krzysztofwolski (#760) to split this task into smaller ones and resolve issues in smaller modules. I propose to go with three steps:For now, you can only manually change storefront language (still quite useful) by setting it in
LocaleProvider
. Also for now I only added one additional language (without translation) just for test.I managed to localize as many strings as I found but some might still be missing. Known things TODO:
AccountMenu
andAccountMenuMobile
linksPlease let me known what do you think about this work and the proposed steps. With your acceptance and guidance, I could try to tackle them.
Screenshots
Pull Request Checklist