Skip to content
This repository was archived by the owner on Jul 14, 2022. It is now read-only.

Language selector #798

Closed
5 tasks
krzysztofwolski opened this issue Jul 2, 2020 · 7 comments
Closed
5 tasks

Language selector #798

krzysztofwolski opened this issue Jul 2, 2020 · 7 comments
Labels

Comments

@krzysztofwolski
Copy link
Member

krzysztofwolski commented Jul 2, 2020

What I'm trying to achieve

Have a way to select the language for the storefront.

Definition of Done

  • modal for language selector should be working both on mobile and desktop
  • footer displays currently chosen language
  • clicking on change located in footer launches language selection modal
  • as default use the English language - we'll switch to browsers default language when translations will be complete
  • when language is changed, save this preference in localStorage

Screenshots or mockups

Desktop design for the modal window:
image

Mobile design for the modal window:
image

Design for footer section:
image

Figma:
https://www.figma.com/file/l4s9dKj8Ch356prygQAxrv/STOREFRONT-CHANGE-LANGUAGE?node-id=0%3A1

Flag icons:
https://github.com/yammadev/flag-icons

@krzysztofwolski
Copy link
Member Author

Note: We are going to use flags as language icons in the initial implementation of this modal. Later on, it will be modified and we will also introduce region (country) selection where the footer flag icon will be moved.

For curious, why flag !== language:
https://localizejs.com/articles/why-using-flag-icons-can-confuse-your-users/

@przlada
Copy link
Member

przlada commented Jul 3, 2020

@krzysztofwolski thanks for materials. I'll try to tackle this "Language selector" feature next week because now I'm in the middle of model translations.

@goldenMetteyya
Copy link

hi has progress been made on this ?

@przlada
Copy link
Member

przlada commented Jul 17, 2020

Not yet, it is still work in progress. Unfortunately, I couldn't find time for it this week. I plan to make PR next week

@przlada przlada mentioned this issue Jul 31, 2020
10 tasks
@stale
Copy link

stale bot commented Sep 15, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 15, 2020
@stale stale bot closed this as completed Sep 22, 2020
@maarcingebala
Copy link
Member

Not stale I guess? cc @krzysztofwolski

@maarcingebala maarcingebala reopened this Sep 22, 2020
@stale stale bot removed the stale label Sep 22, 2020
@stale
Copy link

stale bot commented Nov 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 21, 2020
@stale stale bot closed this as completed Nov 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants