Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests compatible with numpy 2.1 #39242

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Jan 1, 2025

Related to #38250 .

In numpy 2.1 it returns a Token object which gets printed out. This assigns it to _.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@user202729 user202729 mentioned this pull request Jan 1, 2025
5 tasks
Copy link

github-actions bot commented Jan 1, 2025

Documentation preview for this PR (built with commit 773d112; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 7, 2025
As discussed in sagemath#39241 .

Based on mkoeppe@6247975f786c85c35124a66a
0d32df00260461c5 , but also change the template file.

Note that for tests to pass, sagemath#39242
is also needed.

URL: sagemath#39291
Reported by: user202729
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 9, 2025
    
As discussed in sagemath#39241 .

Based on mkoeppe@6247975f786c85c35124a66a
0d32df00260461c5 , but also change the template file.

Note that for tests to pass, sagemath#39242
is also needed.
    
URL: sagemath#39291
Reported by: user202729
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 10, 2025
    
As discussed in sagemath#39241 .

Based on mkoeppe@6247975f786c85c35124a66a
0d32df00260461c5 , but also change the template file.

Note that for tests to pass, sagemath#39242
is also needed.
    
URL: sagemath#39291
Reported by: user202729
Reviewer(s): Tobias Diez
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant