-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test numpy 2 on CI #39241
base: develop
Are you sure you want to change the base?
Test numpy 2 on CI #39241
Conversation
this particular job has the numpy 2 test at https://github.com/sagemath/sage/actions/runs/12572088860/job/35043683578?pr=39241 Testing locally there's a bunch of failing tests because of e.g. #39242
some of them are fpylll issue it seems. |
Documentation preview for this PR (built with commit fa86219; changes) is ready! 🎉 |
See also #39267 for the updated env files. |
I guess this PR wouldn't be necessary when numpy 2 is supported by official conda anyway. Just a test. |
It's a great way to test the changes that are necessary for numpy 2 support. Speaking of, could you please create a new PR for the fix to flint? Thanks! |
As discussed in sagemath#39241 . Based on mkoeppe@6247975f786c85c35124a66a 0d32df00260461c5 , but also change the template file. Note that for tests to pass, sagemath#39242 is also needed. URL: sagemath#39291 Reported by: user202729 Reviewer(s): Tobias Diez
As discussed in sagemath#39241 . Based on mkoeppe@6247975f786c85c35124a66a 0d32df00260461c5 , but also change the template file. Note that for tests to pass, sagemath#39242 is also needed. URL: sagemath#39291 Reported by: user202729 Reviewer(s): Tobias Diez
As discussed in sagemath#39241 . Based on mkoeppe@6247975f786c85c35124a66a 0d32df00260461c5 , but also change the template file. Note that for tests to pass, sagemath#39242 is also needed. URL: sagemath#39291 Reported by: user202729 Reviewer(s): Tobias Diez
As in the title. Temporary workaround.
I guess the current method is rather suboptimal (first numpy 1.26 and fpylll is downloaded, then it is discarded), but better than it not being tested.
A better way may be to generate separate yml files.
Let's see if it works.
📝 Checklist
⌛ Dependencies