Fix monomial_coefficients for submodules of free modules from sage.modules
#37526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoeppe
force-pushed
the
t/34455/fix_monomial_coefficients_for_submodules_of_free_modules_from_sage_modules
branch
from
b6ff351 to
90d480e
Compare
mkoeppe
force-pushed
the
t/34455/fix_monomial_coefficients_for_submodules_of_free_modules_from_sage_modules
branch
from
27f5eb1 to
80db45d
Compare
|
Documentation preview for this PR (built with commit 2eb5de8; changes) is ready! 🎉 |
mkoeppe
force-pushed
the
t/34455/fix_monomial_coefficients_for_submodules_of_free_modules_from_sage_modules
branch
from
80db45d to
629c569
Compare
mkoeppe
force-pushed
the
t/34455/fix_monomial_coefficients_for_submodules_of_free_modules_from_sage_modules
branch
from
629c569 to
a3dfe7b
Compare
mkoeppe
force-pushed
the
t/34455/fix_monomial_coefficients_for_submodules_of_free_modules_from_sage_modules
branch
from
a3dfe7b to
1f69514
Compare
added 15 commits
June 1, 2024 16:42
…ients): Fix for submodules
…ng workaround, delegate to .element()
…nomial_coefficients to raise NotImplementedError
…ients): Use dict only when coordinate ring matches
mkoeppe
force-pushed
the
t/34455/fix_monomial_coefficients_for_submodules_of_free_modules_from_sage_modules
branch
from
cbedff2 to
f719592
Compare
tscrim
requested changes
Jun 2, 2024
| base_ring = self.parent().base_ring() | ||
| if self.parent().is_ambient() and base_ring == self.parent().coordinate_ring(): | ||
| return self.dict(copy=copy) | ||
| else: |
There was a problem hiding this comment.
I find else: statements like this unnecessary and just adding extra (unnecessary) indentation.
There was a problem hiding this comment.
I agree, done in 2eb5de8
…ot is Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
|
Thank you! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 4, 2024
…modules from sage.modules
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
- Rebased version of sagemath#34455
- Part of sagemath#30309
Fixes sagemath#34455
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#37526
Reported by: Matthias Köppe
Reviewer(s): Matthias Köppe, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 5, 2024
…modules from sage.modules
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
- Rebased version of sagemath#34455
- Part of sagemath#30309
Fixes sagemath#34455
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#37526
Reported by: Matthias Köppe
Reviewer(s): Matthias Köppe, Travis Scrimshaw
mkoeppe
deleted the
t/34455/fix_monomial_coefficients_for_submodules_of_free_modules_from_sage_modules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34455
📝 Checklist
⌛ Dependencies