-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta-ticket: Unify free module elements API: methods dict, monomial_coefficients, etc. #30309
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mkoeppe
changed the title
Unify free module elements API: methods dict, monomial_coefficients, etc.
Meta-ticket: Unify free module elements API: methods dict, monomial_coefficients, etc.
Aug 17, 2020
comment:7
Setting new milestone based on a cursory review of ticket status, priority, and last modification date. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Jun 4, 2024
…modules from sage.modules <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> - Rebased version of sagemath#34455 - Part of sagemath#30309 Fixes sagemath#34455 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37526 Reported by: Matthias Köppe Reviewer(s): Matthias Köppe, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Jun 5, 2024
…modules from sage.modules <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> - Rebased version of sagemath#34455 - Part of sagemath#30309 Fixes sagemath#34455 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37526 Reported by: Matthias Köppe Reviewer(s): Matthias Köppe, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Jun 8, 2024
…modules from sage.modules <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> - Rebased version of sagemath#34455 - Part of sagemath#30309 Fixes sagemath#34455 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37526 Reported by: Matthias Köppe Reviewer(s): Matthias Köppe, Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
FreeModule
andCombinatorialFreeModule
elements support methodsmonomials
,coefficients
,monomial_coefficients
, andFreeModule
has the aliasdict
for the latter.FiniteRankFreeModule
elements could support these methods too (with an optionalbasis
argument), andComponents
as well.Tickets:
_element_constructor_
in element classes with mutability_vector_
,vector
andvector_space
MatrixSpace
monomial_coefficients
for submodules of free modules fromsage.modules
monomial_coefficients
for Lie algebras when they are known to be finite dimensionalvector.length()
should be number of nonzero entriesIndexedFreeModuleElement
compatible withcollections.abc
, add methoditems
FreeModuleElement
to theSequence
ABCCombinatorialFreeModule._element_constructor_
: Deprecate initialization from a given indexsupport_section
,coordinate_section
forModulesWithBasis
items
andnonzero_positions
#34511CombinatorialFreeModule.is_ambient
, add element methodsitems
andnonzero_positions
SubspaceFunctor
toCombinatorialFreeModule
CC: @mwageringel @mjungmath @tscrim @videlec @egourgoulhon @fchapoton
Component: linear algebra
Issue created by migration from https://trac.sagemath.org/ticket/30309
The text was updated successfully, but these errors were encountered: