Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polyhedron_base.facet_adjacency_matrix: Do not use face_lattice #33008

Closed
kliem opened this issue Dec 10, 2021 · 6 comments
Closed

Polyhedron_base.facet_adjacency_matrix: Do not use face_lattice #33008

kliem opened this issue Dec 10, 2021 · 6 comments
Labels
c: geometry p: major / 3 t: enhancement
Milestone
sage-9.6

Comments

@kliem
Copy link
Contributor

kliem commented Dec 10, 2021

As was done with #32666.

We also fix the documentation, as the facet adjacency matrix did not and does not treat hyperplanes.

Depends on #32884

CC: @mkoeppe

Component: geometry

Author: Jonathan Kliem

Branch/Commit: 5b854ac

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/33008
@kliem kliem added this to the sage-9.5 milestone Dec 10, 2021
@kliem
Copy link
Contributor Author

kliem commented Dec 10, 2021

Commit: 5b854ac

@kliem
Copy link
Contributor Author

kliem commented Dec 10, 2021

New commits:

7a81ba8move lattice point methods to Polyhedron_base2
10dd56dremove unused import
6a15f92move combinatorics to Polyhedron_base3
f7d87e2fix copy/paste-typo
7c0dd1cMerge branch 'u/gh-kliem/polyhedron_base3' of git://trac.sagemath.org/sage into u/gh-kliem/use_combinatorial_polyhedron
5b854acmove facet adjacency matrix to combinatorial polyhedron

@kliem
Copy link
Contributor Author

kliem commented Dec 10, 2021

Branch: public/33008

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 10, 2021

comment:2

(sorry, wrong ticket)

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 15, 2021

Reviewer: Matthias Koeppe

@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Jan 10, 2022
@vbraun
Copy link
Member

vbraun commented Feb 12, 2022

Changed branch from public/33008 to 5b854ac

@vbraun vbraun closed this as completed in 87011e9 Feb 12, 2022
@kliem kliem mentioned this issue May 11, 2022
Closed
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
@mkoeppe
Merge sagemath#33008
b3f8e7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.6
Development

No branches or pull requests
3 participants
@vbraun @mkoeppe @kliem