Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FriCAS to 1.3.6 #27309

Closed
mantepse opened this issue Feb 17, 2019 · 33 comments
Closed

Update FriCAS to 1.3.6 #27309

mantepse opened this issue Feb 17, 2019 · 33 comments

Comments

@mantepse
Copy link
Collaborator

This ticket is to upgrade to FriCAS 1.3.6 and track dependencies.

Tarball: see checksums.ini

Note that FriCAS has switched to using Git and the primary repository is now the one at GitHub, but the homepage remains at Sourceforge:

and we still get source tarballs from Sourceforge since those available at GitHub are not the full source archives we need.

Our last update was to Fricas 1.3.5 in #25962 in February 2019.

To try this ticket from your Sage root directory, with git-trac-command installed:

  1. git trac try 27309
  2. SAGE_SPKG="sage-spkg -o" ./sage -i fricas (or use ./configure --enable-download-from-upstream-url first)
  3. ./sage -t --optional=fricas,sage src/sage/interfaces/fricas.py

CC: @slel

Component: packages: optional

Keywords: FriCAS, upgrade

Author: Frédéric Chapoton

Branch: b811a1d

Reviewer: Matthias Koeppe, Samuel Lelièvre

Issue created by migration from https://trac.sagemath.org/ticket/27309

@embray
Copy link
Contributor

embray commented Mar 25, 2019

comment:1

Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)

@embray embray modified the milestones: sage-8.7, sage-8.8 Mar 25, 2019
@embray
Copy link
Contributor

embray commented Jun 14, 2019

comment:2

As the Sage-8.8 release milestone is pending, we should delete the sage-8.8 milestone for tickets that are not actively being worked on or that still require significant work to move forward. If you feel that this ticket should be included in the next Sage release at the soonest please set its milestone to the next release milestone (sage-8.9).

@embray embray removed this from the sage-8.8 milestone Jun 14, 2019
@slel
Copy link
Member

slel commented Mar 23, 2020

comment:3

Fricas 1.3.6 was released. Release announcement:

@slel

This comment has been minimized.

@slel slel added this to the sage-9.1 milestone Mar 23, 2020
@mantepse
Copy link
Collaborator Author

comment:4

In case you have time, could you check whether #27310 works?

@mkoeppe mkoeppe modified the milestones: sage-9.1, sage-9.2 Apr 24, 2020
@fchapoton

This comment has been minimized.

@fchapoton
Copy link
Contributor

Commit: 29d0e02

@fchapoton
Copy link
Contributor

New commits:

29d0e02update fricas to 1.3.6

@fchapoton
Copy link
Contributor

Branch: u/chapoton/27309

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 19, 2020

Changed commit from 29d0e02 to 086cbf0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 19, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

086cbf0fix fricas doctest

@fchapoton
Copy link
Contributor

comment:9

Passes all doctests. This seems to be good to go.

@slel

This comment has been minimized.

@slel

This comment has been minimized.

@slel
Copy link
Member

slel commented Aug 19, 2020

comment:11

In build/pkgs/fricas/checksums.ini maybe change:

-tarball=fricas-VERSION-full.tar.bz2
+tarball=fricas-VERSION.tar.gz

@fchapoton
Copy link
Contributor

comment:12

why ?

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 19, 2020

comment:13

I see:

upstream_url=https://github.com/fricas/fricas/archive/VERSION.tar.gz

I don't think this the URL of a release tarball. This is just the automatic git archive corresponding to the tag. Upstream seems to continue using sourceforge for distributing release tarballs.

@slel
Copy link
Member

slel commented Aug 19, 2020

comment:15

In that case do we need in checksums.ini the following (with updated checksums):

tarball=fricas-VERSION-full.tar.bz2
...
upstream_url=https://sourceforge.net/projects/fricas/files/fricas/VERSION/fricas-VERSION-full.tar.bz2/download

Or are these Sourceforge download urls problematic?

@slel

This comment has been minimized.

@slel
Copy link
Member

slel commented Aug 19, 2020

comment:17

Ideally, rebase on Sage 9.2.beta9.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 19, 2020

Changed commit from 086cbf0 to b811a1d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 19, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

b811a1dupdate fricas to 1.3.6

@fchapoton
Copy link
Contributor

comment:19

better like that ?

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 19, 2020

Changed author from Martin Rubey to Frédéric Chapoton

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 19, 2020

Reviewer: Matthias Koeppe

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 19, 2020

comment:23

Works for me on macOS.

@slel
Copy link
Member

slel commented Aug 19, 2020

Changed reviewer from Matthias Koeppe to Matthias Koeppe, Samuel Lelièvre

@slel
Copy link
Member

slel commented Aug 19, 2020

comment:24

Success on Debian too:

$ ./sage -i fricas && ./sage -t --optional=fricas,build,dochtml,sage --all
All tests passed!

@vbraun
Copy link
Member

vbraun commented Aug 20, 2020

Changed branch from u/chapoton/27309 to b811a1d

@fchapoton
Copy link
Contributor

Changed commit from b811a1d to none

@fchapoton
Copy link
Contributor

comment:26

I now have problems with "sage -i fricas", which does not seem to be able to find the tarball in the mirrors..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants