Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FriCAS to 1.3.7 #32049

Closed
mantepse opened this issue Jun 24, 2021 · 16 comments
Closed

Update FriCAS to 1.3.7 #32049

mantepse opened this issue Jun 24, 2021 · 16 comments

Comments

@mantepse
Copy link
Collaborator

This ticket is to upgrade to FriCAS 1.3.7 and track dependencies.

Tarball: see checksums.ini

Note that FriCAS has switched to using Git and the primary repository is now the one at GitHub, but the homepage remains at Sourceforge:

Our last update was to Fricas 1.3.6 in #27309 in 2020.

To try this ticket from your Sage root directory, with git-trac-command installed:

  1. git trac try
  2. SAGE_SPKG="sage-spkg -o" ./sage -i fricas (or use ./configure --enable-download-from-upstream-url first)
  3. ./sage -t --optional=fricas,sage src/sage/interfaces/fricas.py

This release also fixes #28630

CC: @slel @fchapoton

Component: packages: optional

Keywords: fricas

Author: Martin Rubey

Branch/Commit: 2619149

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/32049

@dimpase
Copy link
Member

dimpase commented Jun 27, 2021

comment:2

branch?

@mantepse
Copy link
Collaborator Author

mantepse commented Jul 7, 2021

Branch: u/mantepse/update_fricas_to_1_3_7

@mantepse
Copy link
Collaborator Author

mantepse commented Jul 7, 2021

Commit: 7eeb80c

@mantepse
Copy link
Collaborator Author

mantepse commented Jul 7, 2021

New commits:

7eeb80cupdate fricas to 1.3.7

@mantepse

This comment has been minimized.

@dimpase
Copy link
Member

dimpase commented Jul 8, 2021

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Jul 8, 2021

comment:5

lgtm

@dimpase
Copy link
Member

dimpase commented Jul 8, 2021

comment:6

does not build on macOS:

[fricas-1.3.7.p1] No legacy uninstaller found for 'fricas'; nothing to do
[fricas-1.3.7.p1] Configuring fricas-1.3.7.p1
[fricas-1.3.7.p1] configure: WARNING: unrecognized options: --disable-static, --disable-maintainer-mode, --disable-dependency-tracking
[fricas-1.3.7.p1] checking build system type... x86_64-apple-darwin20.5.0
[fricas-1.3.7.p1] checking host system type... x86_64-apple-darwin20.5.0
[fricas-1.3.7.p1] checking target system type... x86_64-apple-darwin20.5.0
[fricas-1.3.7.p1] checking for in-tree build on case insensitive file system... configure: error: in tree build on case insensitive file system is not supported. Use out-of-source build instead.
[fricas-1.3.7.p1] configure: WARNING: unrecognized options: --disable-static
[fricas-1.3.7.p1] checking build system type... x86_64-apple-darwin20.5.0
[fricas-1.3.7.p1] checking host system type... x86_64-apple-darwin20.5.0
[fricas-1.3.7.p1] checking target system type... x86_64-apple-darwin20.5.0
[fricas-1.3.7.p1] checking for in-tree build on case insensitive file system... configure: error: in tree build on case insensitive file system is not supported. Use out-of-source build instead.
[fricas-1.3.7.p1] ********************************************************************************
[fricas-1.3.7.p1] Error configuring fricas-1.3.7.p1 See the file

@mantepse
Copy link
Collaborator Author

mantepse commented Jul 8, 2021

comment:7

I do not have access to macOS, can you do something about this? Or do you know who could?

@dimpase
Copy link
Member

dimpase commented Jul 8, 2021

comment:8

trying to fix it now. Probably it's a red herring (see fricas/fricas#38), but it needs a patch. I've disabled the test in question and checking if it still works.

@dimpase
Copy link
Member

dimpase commented Jul 8, 2021

comment:9

builds and tests fine with

--- /dev/null
+++ b/build/pkgs/fricas/patches/remove_case_insensitive_test.patch
@@ -0,0 +1,13 @@
+diff --git a/configure b/configure
+index a49f75a..960d412 100755
+--- a/configure
++++ b/configure
+@@ -2470,7 +2470,7 @@ fi
+ 
+ { $as_echo "$as_me:${as_lineno-$LINENO}: checking for in-tree build on case insensitive file system" >&5
+ $as_echo_n "checking for in-tree build on case insensitive file system... " >&6; }
+-if test "$fricas_top_srcdir" = "$fricas_pwd"; then
++if test "$fricas_top_srcdir" = xfoobla; then
+    rm -f ac_TEST_filenames_CASE_sensitive ac_test_filenames_case_sensitive
+    echo foo > ac_test_filenames_case_sensitive
+    if test -f ac_TEST_filenames_CASE_sensitive; then

@dimpase
Copy link
Member

dimpase commented Jul 8, 2021

comment:10

OK, this will do.


New commits:

2619149disable insensitivity of FS check

@dimpase
Copy link
Member

dimpase commented Jul 8, 2021

Changed commit from 7eeb80c to 2619149

@dimpase
Copy link
Member

dimpase commented Jul 8, 2021

@mantepse
Copy link
Collaborator Author

mantepse commented Jul 8, 2021

comment:11

Thank you!

@vbraun
Copy link
Member

vbraun commented Jul 18, 2021

Changed branch from u/dimpase/update_fricas_to_1_3_7 to 2619149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants