Remove transaction confirmation view endpoint #2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PooyaRaki
reviewed
Jan 27, 2025
| @@ -181,7 +181,7 @@ export class NativeStakingMapper { | |||
| ]); | |||
| this.validateDeployment(deployment); | |||
| const publicKeys = this.kilnNativeStakingHelper.splitPublicKeys( | |||
| this.kilnDecoder.decodeValidatorsExit(args.data)!.parameters[0].value, | |||
| this.kilnDecoder.decodeValidatorsExit(args.data)!, | |||
There was a problem hiding this comment.
This is not the concern of this PR but it's usually not a good practice to add ! to the variable when the function return type can be null even though the only case the return type can be null is when the data to decode is not validator exit
There was a problem hiding this comment.
I agree, and it shouldn't be used. However, at this stage the data is that of requestValidatorsExit. We can update it in a follow up PR though.
PooyaRaki
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Transaction confirmation views (
/v1/chains/:chainId/safes/:safeAddress/views/transaction-confirmation) inherently mirrored transaction previews. As such, we previously deprecated it.As the endpoint is no longer used, we can safely remove the implementation. This does that.
Changes
KilnDecodermethods that were dependant on the above