Refactor(Tx decoding): use transaction preview endpoint #4783

katspaugh · 2025-01-15T16:51:43Z

What it solves

The old confirmation-view endpoint was deprecated but there's a new, better, transaction-preview endpoint.

This endpoint returns almost the same response as TransactionDetails and allows us to stop proposing new transactions just to decode them.

How to test it

Test the creation of different types of transactions:

Send ETH
Send tokens
Settings changes
Multisends
Safe App txs
Safe L2 migration
Safe upgrade

A known regression in MigrateToL2 that cannot be fixed with the current approach:

No custom decoding when creating an L2 migration
Decoding will work only for confirmations of an existing tx

Depends on this PR: safe-global/safe-gateway-typescript-sdk#209

github-actions · 2025-01-15T16:51:58Z

Branch preview

✅ Deploy successful!

Website:
https://tx_preview--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook:
https://tx_preview--walletweb.review.5afe.dev/storybook/

github-actions · 2025-01-15T17:02:17Z

Coverage report for `apps/web`

St.^❔	Category	Percentage	Covered / Total
🟡	Statements	77.48% (-0.06% 🔻)	13875/17909
🔴	Branches	56.79% (-0.36% 🔻)	3491/6147
🟡	Functions	62.83% (-0.1% 🔻)	2088/3323
🟡	Lines	78.91% (-0.05% 🔻)	12520/15867

Show new covered files 🐣

St.^❔	File	Statements	Branches	Functions	Lines
🟢	`...` / useTxPreview.ts	84.62%	55.56%	100%	81.82%
🟢	`...` / useTxDetails.ts	90%	100%	100%	87.5%

Show files with reduced coverage 🔻

St.^❔	File	Statements	Branches	Functions	Lines
🟢	`...` / hooks.ts	81.2% (+0.75% 🔼)	72.97% (+0.88% 🔼)	66.67% (-3.33% 🔻)	81.31% (+0.48% 🔼)
🟢	`...` / index.tsx	100%	86.11% (-3.68% 🔻)	100%	100%
🟡	`...` / index.tsx	62.5% (-12.5% 🔻)	10% (-25% 🔻)	33.33% (-16.67% 🔻)	63.89% (-11.11% 🔻)
🔴	`...` / SafeTxProvider.tsx	27.91% (-0.66% 🔻)	0%	36.36%	28.21% (-0.74% 🔻)
🟡	`...` / index.tsx	57.14% (-21.43% 🔻)	0% (-60% 🔻)	0% (-100% 🔻)	61.54% (-15.38% 🔻)
🟡	`...` / index.tsx	78.13% (+1.65% 🔼)	8.33% (-2.19% 🔻)	100%	77.42% (+1.66% 🔼)
🟢	`...` / useTxPendingStatuses.ts	77.5% (-0.83% 🔻)	64.06% (-1.56% 🔻)	68.18%	86.41% (-0.97% 🔻)
🟢	`...` / tokenTransferParams.ts	92.59% (-3.7% 🔻)	80%	80%	95.83%

Test suite run success

1786 tests passing in 241 suites.

Report generated by 🧪jest coverage report action from d71b02f

github-actions · 2025-01-15T17:19:05Z

📦 Next.js Bundle Analysis for @safe-global/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`1.06 MB` (🟡 +68.99 KB)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirty-two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load
`/`	`509 B` (🟢 -1 B)	1.06 MB
`/address-book`	`23.21 KB` (🟡 +143 B)	1.08 MB
`/apps`	`35.97 KB` (🟡 +2.25 KB)	1.09 MB
`/apps/custom`	`34.03 KB` (🟡 +2.25 KB)	1.09 MB
`/apps/open`	`55.56 KB` (🟡 +1.95 KB)	1.11 MB
`/balances`	`30.01 KB` (🟡 +314 B)	1.09 MB
`/balances/nfts`	`9.52 KB` (🟢 -23 B)	1.07 MB
`/bridge`	`2.55 KB` (🟢 -5 B)	1.06 MB
`/cookie`	`8.77 KB` (🟡 +1 B)	1.06 MB
`/home`	`61.54 KB` (🟡 +2.28 KB)	1.12 MB
`/licenses`	`2.46 KB` (🟢 -1 B)	1.06 MB
`/new-safe/advanced-create`	`26.38 KB` (🟢 -72 B)	1.08 MB
`/new-safe/create`	`25.53 KB` (🟢 -64 B)	1.08 MB
`/privacy`	`14.57 KB` (🟡 +2 B)	1.07 MB
`/settings/appearance`	`2.25 KB` (🟡 +1 B)	1.06 MB
`/settings/cookies`	`1.87 KB` (🟡 +1 B)	1.06 MB
`/settings/modules`	`4.06 KB` (🟡 +3 B)	1.06 MB
`/settings/notifications`	`6.34 KB` (🟢 -14.98 KB)	1.06 MB
`/settings/safe-apps`	`20.35 KB` (🟡 +2.08 KB)	1.08 MB
`/settings/security`	`2.34 KB` (🟡 +2 B)	1.06 MB
`/settings/setup`	`30.97 KB` (🟡 +246 B)	1.09 MB
`/share/safe-app`	`7.55 KB` (🟢 -8 B)	1.06 MB
`/stake`	`617 B` (🟢 -2 B)	1.06 MB
`/swap`	`763 B` (🟡 +3 B)	1.06 MB
`/terms`	`12.93 KB` (🟡 +1 B)	1.07 MB
`/transactions`	`99.45 KB` (🟡 +2.88 KB)	1.15 MB
`/transactions/history`	`99.41 KB` (🟡 +2.88 KB)	1.15 MB
`/transactions/messages`	`60.25 KB` (🟡 +1.95 KB)	1.12 MB
`/transactions/msg`	`56.5 KB` (🟡 +1.95 KB)	1.11 MB
`/transactions/queue`	`49.36 KB` (🟡 +1.96 KB)	1.1 MB
`/transactions/tx`	`48.71 KB` (🟡 +1.95 KB)	1.1 MB
`/welcome/accounts`	`408 B` (🟡 +1 B)	1.06 MB

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

iamacook · 2025-01-16T12:50:54Z

apps/web/src/components/transactions/TxDetails/TxData/DecodedData/index.tsx

@@ -18,6 +18,8 @@ interface Props {
  toInfo?: AddressEx
 }

+const INTERACTED_WITH = 'Interacted with:'


Nit: this component is often used in the transaction flow meaning that it isn't yet executed so I think present tense makes more sense.

True, will restore it.

apps/web/src/components/transactions/TxDetails/TxData/index.tsx

apps/web/src/components/tx/DecodedTx/index.tsx

iamacook · 2025-01-16T13:08:22Z

apps/web/src/components/tx/DecodedTx/index.tsx

@@ -122,7 +94,7 @@ const DecodedTx = ({
                </>
              )}

-              {txDetails && !showDecodedData && !isCreation ? (


For other reviewers: this change confused me at first but the creation transaction renders fine.

Yes, this change is not obvious. Before, isCreation was true if there are no signatures in txDetails. Because there was always txDetails even before signing. But now, there's no txDetails when creating a tx.

…preview

francovenica · 2025-01-17T13:26:34Z

When migrating a safe to L2 Blockaid takes it as a possible threat. Is this avoidable?

To test this create a safe in ETH using advanced-create, so is a 1.3.0 safe, then use the "add network" to redeploy that address into polygon, activate that polygon safe and lastly try to add an owner to that safe.

katspaugh · 2025-01-17T14:22:55Z

@francovenica fixed the "unsupported base contract" warning.

francovenica · 2025-01-20T02:03:08Z

Note: the issue of blockaid is acutally also in dev, so is not an issue.
I was able to see that the error message "This safe account was created with..." was removed

LGTM

Question: This PR has the tx notes for safes 1/x. Will this be cherry piecked out before merging? or will merged with it?

katspaugh · 2025-01-20T07:41:56Z

@francovenica tx notes now work for 1/X safes thanks to this PR.

Refactor(Tx decoding): use transaction preview endpoint

0f3ae9f

katspaugh requested review from clovisdasilvaneto and usame-algan January 15, 2025 16:51

katspaugh requested a review from iamacook January 15, 2025 16:52

Rm useDecodeTx

ddd4f54

Lint & tests

6c69663

Fix tests

f27dd6b

katspaugh mentioned this pull request Jan 16, 2025

Fix(Tx notes): hide for 1/X safes #4785

Merged

Code style

f3c93c6

katspaugh marked this pull request as ready for review January 16, 2025 08:27

iamacook approved these changes Jan 16, 2025

View reviewed changes

katspaugh added 2 commits January 16, 2025 18:32

Restore "Interact with"

7a896c3

Merge branch 'dev' of github.com:safe-global/safe-wallet-web into tx-…

10a41d6

…preview

Update CGW SDK and fix unknowncontractwarning for L2 migration

3067fd2

katspaugh force-pushed the tx-preview branch from ad9c162 to 3067fd2 Compare January 17, 2025 14:56

Fix safeTxError state

d71b02f

katspaugh force-pushed the tx-preview branch from 141b599 to d71b02f Compare January 20, 2025 07:47

katspaugh merged commit bebed8f into dev Jan 20, 2025
15 checks passed

katspaugh deleted the tx-preview branch January 20, 2025 08:02

github-actions bot locked and limited conversation to collaborators Jan 20, 2025

katspaugh added this to the 1.50.0 milestone Jan 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor(Tx decoding): use transaction preview endpoint #4783

Refactor(Tx decoding): use transaction preview endpoint #4783

katspaugh commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025 •

edited

Loading

iamacook Jan 16, 2025

katspaugh Jan 16, 2025

iamacook Jan 16, 2025

katspaugh Jan 16, 2025 •

edited

Loading

francovenica commented Jan 17, 2025

katspaugh commented Jan 17, 2025

francovenica commented Jan 20, 2025

katspaugh commented Jan 20, 2025

Refactor(Tx decoding): use transaction preview endpoint #4783

Refactor(Tx decoding): use transaction preview endpoint #4783

Conversation

katspaugh commented Jan 15, 2025 • edited Loading

What it solves

How to test it

github-actions bot commented Jan 15, 2025 • edited Loading

Branch preview

github-actions bot commented Jan 15, 2025 • edited Loading

Coverage report for apps/web

Test suite run success

github-actions bot commented Jan 15, 2025 • edited Loading

📦 Next.js Bundle Analysis for @safe-global/web

⚠️ Global Bundle Size Increased

Thirty-two Pages Changed Size

iamacook Jan 16, 2025

Choose a reason for hiding this comment

katspaugh Jan 16, 2025

Choose a reason for hiding this comment

iamacook Jan 16, 2025

Choose a reason for hiding this comment

katspaugh Jan 16, 2025 • edited Loading

Choose a reason for hiding this comment

francovenica commented Jan 17, 2025

katspaugh commented Jan 17, 2025

francovenica commented Jan 20, 2025

katspaugh commented Jan 20, 2025

katspaugh commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025 •

edited

Loading

Coverage report for `apps/web`

github-actions bot commented Jan 15, 2025 •

edited

Loading

katspaugh Jan 16, 2025 •

edited

Loading