Cache descriptors on first access #1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #1701 +/- ##
==========================================
+ Coverage 81.66% 81.74% +0.08%
==========================================
Files 191 191
Lines 17913 17934 +21
Branches 3843 3845 +2
==========================================
+ Hits 14628 14660 +32
+ Misses 2997 2986 -11
Partials 288 288
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@rytilahti could you review/merge this? |
rytilahti
reviewed
Jan 30, 2023
Co-authored-by: Teemu R. <tpr@iki.fi>
rytilahti
reviewed
Jan 30, 2023
|
@rytilahti the tests are actually succesfull, there is an error uploading the codecov.... |
rytilahti
reviewed
Jan 30, 2023
| mocker.patch("miio.Device._sensor_descriptors_from_status", return_value={}) | ||
| mocker.patch("miio.Device._setting_descriptors_from_status", return_value={}) | ||
| mocker.patch("miio.Device._action_descriptors", return_value={}) | ||
| for _i in range(5): |
There was a problem hiding this comment.
Just for the future, the proper way to do this is to use plain _ here. No need to fix that now though.
|
@rytilahti all tests have passed |
rytilahti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The descriptors accessed through
sensors(),settings(), andactions()are now cached on the first use to avoid unnecessary I/O.follow up on PR #1592 which got merge conflicts and is closed.