-
-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix settings request when retrieve_choices_function()
fails
#1702
Comments
It would be better if the attribute access would do no I/O at all. Or at least, as the name ( |
Well in the case of the roborock map_list we need to do I/O to get the amount and names of the maps to which we can switch. This info can only be retrieved from the vacuum using I/O. I don't see a way around that. |
But if the regular update cycle retrieves that data (as discussed briefly in that other PR), it would be already available in whatever container the information from the map list command is stored :-) |
Yes that could work if we would make the call to retrieve the map data part of the main update cycle. |
Accessing
choices_attribute
of the enumsettingdescriptor may cause an exception.Originally posted by @rytilahti in #1701 (comment)
The text was updated successfully, but these errors were encountered: