gateway: remove click support for gateway devices #1229

starkillerOG · 2021-12-12T12:01:35Z

see home-assistant/core#61234 (comment)
the new python-miio release broke the alarm and light entity of the gateway

(by rytilahti: the click support was never working for these "subdevices" as they require to be initialized with the gateway instance. this fixes the issue by avoiding calling info()/accessing model – which is done automatically since #1038 – on a device instance that has no host nor token.)

starkillerOG · 2021-12-12T12:03:39Z

@rytilahti could you have a look at this since the current HomeAssistant release the alarm and gateway light entities are broken

codecov-commenter · 2021-12-12T12:05:30Z

Codecov Report

Merging #1229 (f893ce0) into master (b633844) will increase coverage by 3.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1229      +/-   ##
==========================================
+ Coverage   76.10%   79.20%   +3.10%     
==========================================
  Files          76       90      +14     
  Lines        8926     9696     +770     
  Branches      750     1130     +380     
==========================================
+ Hits         6793     7680     +887     
+ Misses       1950     1824     -126     
- Partials      183      192       +9

Impacted Files	Coverage Δ
miio/gateway/alarm.py	`55.55% <ø> (-15.18%)`	⬇️
miio/gateway/light.py	`27.27% <ø> (-13.03%)`	⬇️
miio/gateway/radio.py	`52.50% <ø> (-6.20%)`	⬇️
miio/gateway/zigbee.py	`57.14% <ø> (-10.72%)`	⬇️
miio/gateway/gatewaydevice.py	`66.66% <100.00%> (-2.57%)`	⬇️
miio/fan_miot.py	`84.89% <0.00%> (-0.06%)`	⬇️
miio/__init__.py	`100.00% <0.00%> (ø)`
miio/waterpurifier.py	`100.00% <0.00%> (ø)`
miio/viomivacuum.py
miio/roidmivacuum_miot.py
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b633844...f893ce0. Read the comment docs.

scxs535 · 2021-12-12T13:59:13Z

@rytilahti same problem here.
@starkillerOG thanks

rytilahti · 2021-12-12T15:32:06Z

The real fix is not removing the click support but to avoid doing model detection on those subdevices which do not have a host themselves, I overlooked this issue when I added the model detection, sorry...

I created a PR, but someone with a test device should give it a try before I merge it :-)

scxs535 · 2021-12-12T15:39:50Z

@rytilahti
how can we test this exactly?

rytilahti · 2021-12-13T00:28:48Z

@scxs535 you have to clone this PR and use that checkout in your setup. If you are not sure how to do that in your system, it's easier to wait for now.

@starkillerOG could you please create a very simple test script to see what happens if you call info() or try to access model on alarm or light? That should crash, but if you take the couple of assignments from my earlier PR, it should start working again.

edit: oh, there's another option that's possible: pass the host, token et. al. to the gateway device constructors, so that they can acquire the info as usual. The downside is that those queries will not be routed through the main instance and will cause I/O, if I'm not mistaken?

miio/gateway/gatewaydevice.py

starkillerOG · 2021-12-14T11:08:26Z

Tested again and it works.
@rytilahti Could you revieuw again/merge?

starkillerOG · 2021-12-14T11:13:02Z

@scxs535 you have to clone this PR and use that checkout in your setup. If you are not sure how to do that in your system, it's easier to wait for now.

@starkillerOG could you please create a very simple test script to see what happens if you call info() or try to access model on alarm or light? That should crash, but if you take the couple of assignments from my earlier PR, it should start working again.

edit: oh, there's another option that's possible: pass the host, token et. al. to the gateway device constructors, so that they can acquire the info as usual. The downside is that those queries will not be routed through the main instance and will cause I/O, if I'm not mistaken?

I don't really want to do any calls from the subdevice itself, but only invoke calls to the parent object (gateway). Also because the message id will not be properly incremented which could potentially cause issues. (otherwise there would be 2 messages ids that are incrementing at diffrent times and that could get messy).

rytilahti

LGTM, thanks for stepping up so quickly to fix this @starkillerOG! 👍

This release fixes regressions caused by the recent refactoring related to supported models: * philips_bulb now defaults to a bulb that has color temperature setting * gateway devices do not perform an info query as that is handled by their parent Also, the list of the supported models was extended thanks to the feedback from the community! [Full Changelog](0.5.9.1...0.5.9.2) **Implemented enhancements:** - Add yeelink.bhf\_light.v2 and yeelink.light.lamp22 support [\#1250](#1250) ([FaintGhost](https://github.com/FaintGhost)) - Skip warning if the unknown model is reported on a base class [\#1243](#1243) ([rytilahti](https://github.com/rytilahti)) - Add emptying bin status for roborock s7+ [\#1190](#1190) ([rytilahti](https://github.com/rytilahti)) **Fixed bugs:** - Fix Roborock S7 fan speed [\#1235](#1235) ([shred86](https://github.com/shred86)) - gateway: remove click support for gateway devices [\#1229](#1229) ([starkillerOG](https://github.com/starkillerOG)) - mirobo: make sure config always exists [\#1207](#1207) ([rytilahti](https://github.com/rytilahti)) - Fix typo [\#1204](#1204) ([com30n](https://github.com/com30n)) **Merged pull requests:** - philips\_eyecare: add philips.light.sread1 as supported [\#1246](#1246) ([rytilahti](https://github.com/rytilahti)) - Add yeelink.light.color3 support [\#1245](#1245) ([Kirmas](https://github.com/Kirmas)) - Use codecov-action@v2 for CI [\#1244](#1244) ([rytilahti](https://github.com/rytilahti)) - Add yeelink.light.color5 support [\#1242](#1242) ([Kirmas](https://github.com/Kirmas)) - Add more supported devices to their corresponding classes [\#1237](#1237) ([rytilahti](https://github.com/rytilahti)) - Add zhimi.humidfier.ca4 as supported model [\#1220](#1220) ([jbouwh](https://github.com/jbouwh)) - vacuum: Add t7s \(roborock.vacuum.a14\) [\#1214](#1214) ([rytilahti](https://github.com/rytilahti)) - philips\_bulb: add philips.light.downlight to supported devices [\#1212](#1212) ([rytilahti](https://github.com/rytilahti))

manu3b1 · 2021-12-15T08:05:06Z

With 0.5.9.2 release, with a lumi.gateway.v3-MW300, Alarm and Luminance entities are present, but still no Light.

rytilahti · 2021-12-15T15:33:37Z

@manu3b1 please open a new issue on that and provide some logs so that we have something that can be used to figure out why it isn't working. @starkillerOG do you have a v3? Are you also experiencing the missing light?

manu3b1 · 2021-12-15T19:26:37Z

Light is back with HA 2021.12.2.
Thx!

scxs535 · 2021-12-15T19:32:51Z

everything(alarm & light) works well as before after update to 2021.12.2. 👍
thanks @starkillerOG @rytilahti

rytilahti · 2021-12-15T21:39:22Z

Glad to hear it's working and sorry for the inconvenience! It's rather hard to perform refactoring already on a code base size of this even when one tries to be careful.. Thanks for reporting back @scxs535 :-)

maury77 · 2021-12-15T21:58:01Z

for me no , I have removed the integration and now

Nuovo tentativo di configurazione: DeviceException during setup of xiaomi gateway with host {self._host}

starkillerOG · 2021-12-15T22:41:46Z

I tested on my setup with gateway.v3 and both the alarm, illumination and light entities all work on the latest 2012.12.2 release.

@maury77 do you have anything else in the log?
Did you set it up using the cloud credentials and are you sure you have the correct credentials and selected the correct server?

maury77 · 2021-12-16T08:45:26Z

The cloud connectio si ok

configuration

but

dic 16 09:42:19 sdomotica homeassistant[32525]: 2021-12-16 09:42:19 WARNING (MainThread) [homeassistant.config_entries] Config entry 'hub mare' for xiaomi_miio integration not ready yet: DeviceException during setup of xiaomi gateway with host {self._host}; Retrying in background

Seems a timeout but the device is reacheble

I upgrade the version of the device to 3.1.3_0004

starkillerOG · 2021-12-16T08:56:20Z

@maury77 did you try power cycling the hub (plugin out, wait 15 seconds, plug back in)?
Did this hub work before for you?

maury77 · 2021-12-16T09:04:01Z

In this moment I can't turn it off because the gw is in other city, before
it worked in 2012.11.X

but i also updated the firmware

therefore the combination of new firmware and new Ha has never been tested

starkillerOG · 2021-12-16T09:12:58Z

@maury77 if possible could you try the old HA version 2021.11.X with the new firmware to make sure it is not a firmware problem?
(maybe in a dev enviroment if you have one).

starkillerOG · 2021-12-16T09:14:27Z

I dont have a aqhm01 gateway (I have v3) so I cant test myself, the .v3 gateway works with HA 2021.12.2

maury77 · 2022-01-06T13:38:30Z

I dont have a aqhm01 gateway (I have v3) so I cant test myself, the .v3 gateway works with HA 2021.12.2

With last version and reboot now is ok

fix gateway devices

9796274

rytilahti mentioned this pull request Dec 12, 2021

gateway: use main device model for subdevices #1233

Closed

rytilahti changed the title ~~fix gateway devices~~ gateway: remove click support for gateway devices Dec 13, 2021

rytilahti reviewed Dec 13, 2021

View reviewed changes

miio/gateway/gatewaydevice.py Show resolved Hide resolved

Do not inherit from Device on gatewaydevices

f893ce0

rytilahti approved these changes Dec 14, 2021

View reviewed changes

rytilahti merged commit ee88751 into rytilahti:master Dec 14, 2021

scxs535 mentioned this pull request Dec 14, 2021

Xiaomi Miio - lumi.gateway.aqhm01. after upgrade home-assistant/core#61612

Closed

rytilahti added the bug label Dec 14, 2021

rytilahti mentioned this pull request Dec 14, 2021

Release 0.5.9.2 #1251

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gateway: remove click support for gateway devices #1229

gateway: remove click support for gateway devices #1229

starkillerOG commented Dec 12, 2021 •

edited by rytilahti

Loading

starkillerOG commented Dec 12, 2021

codecov-commenter commented Dec 12, 2021 •

edited

Loading

scxs535 commented Dec 12, 2021

rytilahti commented Dec 12, 2021 •

edited

Loading

scxs535 commented Dec 12, 2021

rytilahti commented Dec 13, 2021 •

edited

Loading

starkillerOG commented Dec 14, 2021

starkillerOG commented Dec 14, 2021

rytilahti left a comment

manu3b1 commented Dec 15, 2021

rytilahti commented Dec 15, 2021

manu3b1 commented Dec 15, 2021

scxs535 commented Dec 15, 2021 •

edited

Loading

rytilahti commented Dec 15, 2021

maury77 commented Dec 15, 2021

starkillerOG commented Dec 15, 2021

maury77 commented Dec 16, 2021

starkillerOG commented Dec 16, 2021

maury77 commented Dec 16, 2021

starkillerOG commented Dec 16, 2021

starkillerOG commented Dec 16, 2021

maury77 commented Jan 6, 2022

gateway: remove click support for gateway devices #1229

gateway: remove click support for gateway devices #1229

Conversation

starkillerOG commented Dec 12, 2021 • edited by rytilahti Loading

starkillerOG commented Dec 12, 2021

codecov-commenter commented Dec 12, 2021 • edited Loading

Codecov Report

scxs535 commented Dec 12, 2021

rytilahti commented Dec 12, 2021 • edited Loading

scxs535 commented Dec 12, 2021

rytilahti commented Dec 13, 2021 • edited Loading

starkillerOG commented Dec 14, 2021

starkillerOG commented Dec 14, 2021

rytilahti left a comment

Choose a reason for hiding this comment

manu3b1 commented Dec 15, 2021

rytilahti commented Dec 15, 2021

manu3b1 commented Dec 15, 2021

scxs535 commented Dec 15, 2021 • edited Loading

rytilahti commented Dec 15, 2021

maury77 commented Dec 15, 2021

starkillerOG commented Dec 15, 2021

maury77 commented Dec 16, 2021

starkillerOG commented Dec 16, 2021

maury77 commented Dec 16, 2021

starkillerOG commented Dec 16, 2021

starkillerOG commented Dec 16, 2021

maury77 commented Jan 6, 2022

starkillerOG commented Dec 12, 2021 •

edited by rytilahti

Loading

codecov-commenter commented Dec 12, 2021 •

edited

Loading

rytilahti commented Dec 12, 2021 •

edited

Loading

rytilahti commented Dec 13, 2021 •

edited

Loading

scxs535 commented Dec 15, 2021 •

edited

Loading