Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zhimi.humidfier.ca4 as supported model #1220

Merged
merged 2 commits into from
Dec 9, 2021

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Dec 9, 2021

Add SmartMI evaporative Humidifier 2 (zhimi.humidfier.ca4) as supported device

Fixes #1219

@jbouwh jbouwh changed the title SMARTMI_EVAPORATIVE_HUMIDIFIER_2 = "zhimi.humidfier.ca4" SUPPORTED_MODELS = [SMARTMI_EVAPORATIVE_HUMIDIFIER_2] Add zhimi.humidfier.ca4 Dec 9, 2021
@jbouwh jbouwh changed the title Add zhimi.humidfier.ca4 Add zhimi.humidfier.ca4 as supported model Dec 9, 2021
@jbouwh
Copy link
Contributor Author

jbouwh commented Dec 9, 2021

#1219

@rytilahti
Copy link
Owner

Thanks, looks like I missed that one 👍 Please fix the linting (tox -e lint or pre-commit run -a) and this is good to go.

@jbouwh
Copy link
Contributor Author

jbouwh commented Dec 9, 2021

fixed linting, thnx

@rytilahti rytilahti merged commit 4342e3d into rytilahti:master Dec 9, 2021
@jbouwh jbouwh deleted the add-zhimi.humidfier.ca4 branch December 11, 2021 14:52
impankratov pushed a commit to impankratov/python-miio that referenced this pull request Dec 12, 2021
* Add zhimi.humidfier.ca4 as supported model

* fix lint
rytilahti added a commit that referenced this pull request Dec 14, 2021
This release fixes regressions caused by the recent refactoring related to supported models:
* philips_bulb now defaults to a bulb that has color temperature setting
* gateway devices do not perform an info query as that is handled by their parent

Also, the list of the supported models was extended thanks to the feedback from the community!

[Full Changelog](0.5.9.1...0.5.9.2)

**Implemented enhancements:**

- Add yeelink.bhf\_light.v2 and yeelink.light.lamp22 support [\#1250](#1250) ([FaintGhost](https://github.com/FaintGhost))
- Skip warning if the unknown model is reported on a base class [\#1243](#1243) ([rytilahti](https://github.com/rytilahti))
- Add emptying bin status for roborock s7+ [\#1190](#1190) ([rytilahti](https://github.com/rytilahti))

**Fixed bugs:**

- Fix Roborock S7 fan speed [\#1235](#1235) ([shred86](https://github.com/shred86))
- gateway: remove click support for gateway devices [\#1229](#1229) ([starkillerOG](https://github.com/starkillerOG))
- mirobo: make sure config always exists [\#1207](#1207) ([rytilahti](https://github.com/rytilahti))
- Fix typo [\#1204](#1204) ([com30n](https://github.com/com30n))

**Merged pull requests:**

- philips\_eyecare: add philips.light.sread1 as supported [\#1246](#1246) ([rytilahti](https://github.com/rytilahti))
- Add yeelink.light.color3 support [\#1245](#1245) ([Kirmas](https://github.com/Kirmas))
- Use codecov-action@v2 for CI [\#1244](#1244) ([rytilahti](https://github.com/rytilahti))
- Add yeelink.light.color5 support [\#1242](#1242) ([Kirmas](https://github.com/Kirmas))
- Add more supported devices to their corresponding classes [\#1237](#1237) ([rytilahti](https://github.com/rytilahti))
- Add zhimi.humidfier.ca4 as supported model [\#1220](#1220) ([jbouwh](https://github.com/jbouwh))
- vacuum: Add t7s \(roborock.vacuum.a14\) [\#1214](#1214) ([rytilahti](https://github.com/rytilahti))
- philips\_bulb: add philips.light.downlight to supported devices [\#1212](#1212) ([rytilahti](https://github.com/rytilahti))
@rytilahti rytilahti mentioned this pull request Dec 14, 2021
rytilahti added a commit that referenced this pull request Dec 14, 2021
This release fixes regressions caused by the recent refactoring related to supported models:
* philips_bulb now defaults to a bulb that has color temperature setting
* gateway devices do not perform an info query as that is handled by their parent

Also, the list of the supported models was extended thanks to the feedback from the community!

[Full Changelog](0.5.9.1...0.5.9.2)

**Implemented enhancements:**

- Add yeelink.bhf\_light.v2 and yeelink.light.lamp22 support [\#1250](#1250) ([FaintGhost](https://github.com/FaintGhost))
- Skip warning if the unknown model is reported on a base class [\#1243](#1243) ([rytilahti](https://github.com/rytilahti))
- Add emptying bin status for roborock s7+ [\#1190](#1190) ([rytilahti](https://github.com/rytilahti))

**Fixed bugs:**

- Fix Roborock S7 fan speed [\#1235](#1235) ([shred86](https://github.com/shred86))
- gateway: remove click support for gateway devices [\#1229](#1229) ([starkillerOG](https://github.com/starkillerOG))
- mirobo: make sure config always exists [\#1207](#1207) ([rytilahti](https://github.com/rytilahti))
- Fix typo [\#1204](#1204) ([com30n](https://github.com/com30n))

**Merged pull requests:**

- philips\_eyecare: add philips.light.sread1 as supported [\#1246](#1246) ([rytilahti](https://github.com/rytilahti))
- Add yeelink.light.color3 support [\#1245](#1245) ([Kirmas](https://github.com/Kirmas))
- Use codecov-action@v2 for CI [\#1244](#1244) ([rytilahti](https://github.com/rytilahti))
- Add yeelink.light.color5 support [\#1242](#1242) ([Kirmas](https://github.com/Kirmas))
- Add more supported devices to their corresponding classes [\#1237](#1237) ([rytilahti](https://github.com/rytilahti))
- Add zhimi.humidfier.ca4 as supported model [\#1220](#1220) ([jbouwh](https://github.com/jbouwh))
- vacuum: Add t7s \(roborock.vacuum.a14\) [\#1214](#1214) ([rytilahti](https://github.com/rytilahti))
- philips\_bulb: add philips.light.downlight to supported devices [\#1212](#1212) ([rytilahti](https://github.com/rytilahti))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add model SmartMI Evaporative Humidifier 2 (zhimi.humidfier.ca4)
2 participants