Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create advisory for unmaintained paste crate #2215

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

AS1100K
Copy link
Contributor

@AS1100K AS1100K commented Jan 31, 2025

Fixes #2203

@AS1100K AS1100K force-pushed the paste-unmaintained branch from 83e567d to 8278798 Compare February 1, 2025 18:55
@tarcieri tarcieri merged commit 610b1ae into rustsec:main Mar 7, 2025
1 check passed
@decathorpe
Copy link
Contributor

FWIW I maintain the package for this crate in Fedora Linux, and 150+ of our packages depend on it. As such, I'll likely need to keep it around basically forever anyway, and would also contribute some maintenance if needed. I assume the debian packagers will be in a similar boat. Not sure if that would be enough to revoke this "unmaintained" advisory. (I would have filed an issue on the "paste" repo, but it is already archived so issues are read-only.)

EliahKagan added a commit to EliahKagan/gitoxide that referenced this pull request Mar 8, 2025
https://rustsec.org/advisories/RUSTSEC-2024-0436.html now causes
the `cargo deny advisories` check to fail (even if the separate and
more important failure from `ring` is changed by bumping the `ring`
version, as in GitoxideLabs#1878).

`paste` is mature and would be hard to remove as a transitive
dependency at this time:

    > cargo tree --invert paste --no-dedupe --depth 3
    paste v1.0.15 (proc-macro)
    └── ratatui v0.26.3
        ├── crosstermion v0.14.0
        │   ├── gitoxide v0.41.0 (C:\Users\ek\source\repos\gitoxide)
        │   └── prodash v29.0.0
        ├── prodash v29.0.0
        │   ├── gitoxide v0.41.0 (C:\Users\ek\source\repos\gitoxide)
        │   ├── gix v0.70.0 (C:\Users\ek\source\repos\gitoxide\gix)
        │   └── gix-features v0.40.0 (C:\Users\ek\source\repos\gitoxide\gix-features)
        └── tui-react v0.23.2
            ├── crosstermion v0.14.0
            └── prodash v29.0.0

As discussed in rustsec/advisory-db#2215
and leptos-rs/leptos#3685, `paste` is
widely used and there is community interest in maintaining it.

When the status changes or more information about the future of
`paste` or its alternatives is available, `deny.toml` could be
updated again (even if only with a comment).
@AS1100K AS1100K deleted the paste-unmaintained branch March 9, 2025 19:26
@AS1100K
Copy link
Contributor Author

AS1100K commented Mar 9, 2025

I have created a crate named pastey. This crate is the fork of paste and is a direct drop in replacement for paste crate along with some other features and bug fixes that paste was lacking.
Although, this crate is new and I am fully into maintaining it, can we edit this advisory to recommend this crate as an alternative?

EliahKagan added a commit to EliahKagan/gitoxide that referenced this pull request Mar 9, 2025
https://rustsec.org/advisories/RUSTSEC-2024-0436.html now causes
the `cargo deny advisories` check to fail (even if the separate and
more important failure from `ring` is fixed by bumping the `ring`
version, as in GitoxideLabs#1878).

`paste` is mature and would be hard to remove as a transitive
dependency at this time:

    > cargo tree --invert paste --no-dedupe --depth 3
    paste v1.0.15 (proc-macro)
    └── ratatui v0.26.3
        ├── crosstermion v0.14.0
        │   ├── gitoxide v0.41.0 (C:\Users\ek\source\repos\gitoxide)
        │   └── prodash v29.0.0
        ├── prodash v29.0.0
        │   ├── gitoxide v0.41.0 (C:\Users\ek\source\repos\gitoxide)
        │   ├── gix v0.70.0 (C:\Users\ek\source\repos\gitoxide\gix)
        │   └── gix-features v0.40.0 (C:\Users\ek\source\repos\gitoxide\gix-features)
        └── tui-react v0.23.2
            ├── crosstermion v0.14.0
            └── prodash v29.0.0

As discussed in rustsec/advisory-db#2215
and leptos-rs/leptos#3685, `paste` is
widely used and there is community interest in maintaining it.

When the status changes or more information about the future of
`paste` or its alternatives is available, `deny.toml` could be
updated again (even if only with a comment).
@tarcieri
Copy link
Member

tarcieri commented Mar 9, 2025

It would be nice to get @dtolnay's blessing on any forks we explicitly name in the advisory

@dtolnay
Copy link
Contributor

dtolnay commented Mar 10, 2025

I don't plan to endorse a particular replacement, but it doesn't make a difference to me. For my own use cases I would use paste since it is 'finished' and does everything I need. Perhaps it would be better for it to be vetted by someone whose use case is not already met by paste.

@decathorpe
Copy link
Contributor

If the project is essentially "done", then I would feel competent to do enough "maintenance" for this advisory to be withdrawn. I am already responsible for the Fedora Linux package for this crate, so I need to keep it around either way.

To make it explicit, I offer to do this if the "dtolnay/paste" repo is unarchived & transferred to me (or to the commons-rs org, which I have set up for situations like this a while ago).

The crate is also packaged for Debian and I would reach out to its maintainers if they want to contribute as well.

ia0 added a commit to google/wasefire that referenced this pull request Mar 12, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
The following findings are not fixed:
- `paste` is "finished:
rustsec/advisory-db#2215 (comment)
- `ring` will be fixed by OpenSK
- `proc-macro-error` will be fixed by Yew:
yewstack/yew#3752
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

paste is unmaintained
5 participants