Remove use of paste library.
#60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`paste` has been given an “unmaintained” advisory and that means, regardless of whether it is still any good, people will get warnings for having it in their transitive dependencies. I would like to avoid that. Luckily, it turns out that we can just replace all of the token pasting with generic code. (Rust 1.79 added the `num::NonZero<T>` generic type, too, but that isn’t actually helping us because the `ZeroablePrimitive` trait it depends on is still unstable — so we still need to define separate concrete implementations.) If a need for `paste`-like functionality comes up again, we can consider adding the functionality to our own `exhaust-macros`, look at what alternatives have developed by then, or see whether the RustSec policy has gained more nuance about “unmaintained” vs “done” status. But for now, this is one fewer dependency, quite cheaply, and less fuss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pastehas been given an “unmaintained” advisory and that means, regardless of whether it is still any good, people will get warnings for having it in their transitive dependencies. I would like to avoid that.Luckily, it turns out that we can just replace all of the token pasting with generic code. (Rust 1.79 added the
num::NonZero<T>generic type, too, but that isn’t actually helping us because theZeroablePrimitivetrait it depends on is still unstable — so we still need to define separate concrete implementations.)If a need for
paste-like functionality comes up again, we can consider adding the functionality to our ownexhaust-macros, look at what alternatives have developed by then, or see whether the RustSec policy has gained more nuance about “unmaintained” vs “done” status. But for now, this is one fewer dependency, quite cheaply, and less fuss.