Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.11.4 is updating MSRV to 1.82.0 #29

Closed
AurelienFT opened this issue Jan 21, 2025 · 3 comments
Closed

0.11.4 is updating MSRV to 1.82.0 #29

AurelienFT opened this issue Jan 21, 2025 · 3 comments

Comments

@AurelienFT
Copy link

Hello,

Thanks for the work in the maintenance of this crate :)

We spotted that you made an update yesterday and this update use is_none_or function which has been introduced in Rust 1.82.0 which requires all users of this crate to use this version at least.

As it was on a patch version Cargo resolves all 0.11.x to 0.11.4 which breaks the compilation if the project rely on a older version.

What do you want to do from this ? If it's expected then I'm ok to make a PR to add the MSRV more explicit using Rust tools or if it wasn't expected maybe it's better to do it on a 0.12 version.

Thanks again for your work on this crate !

@erhant
Copy link

erhant commented Jan 22, 2025

Usage of is_none_or broke some of our workflows that were using a prior rustc as well. It appears to be used in https://github.com/rust-netlink/netlink-proto/blob/main/src/connection.rs#L243 alone, perhaps it is better to not use this function here?

EHfive added a commit to EHfive/einat-ebpf that referenced this issue Jan 24, 2025
@cathay4t
Copy link
Member

cathay4t commented Jan 26, 2025

The netlink-proto 0.11.5 has published with minimum supported rust version set to 1.75 with CI protected.

Sorry for the mess.

@AurelienFT
Copy link
Author

Thank you for the fast reaction ! :)

AurelienFT added a commit to FuelLabs/fuel-core that referenced this issue Jan 28, 2025
## Description

`netlink-proto` released a new version to downgrade MSRV :
rust-netlink/netlink-proto#29 (comment)

## Checklist
- [x] Breaking changes are clearly marked as such in the PR description
and changelog
- [x] New behavior is reflected in tests
- [x] [The specification](https://github.com/FuelLabs/fuel-specs/)
matches the implemented behavior (link update PR if changes are needed)

### Before requesting review
- [x] I have reviewed the code myself
- [x] I have created follow-up issues caused by this PR and linked them
here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants