Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove netlink proto fix #2637

Merged
merged 6 commits into from
Jan 28, 2025
Merged

Remove netlink proto fix #2637

merged 6 commits into from
Jan 28, 2025

Conversation

AurelienFT
Copy link
Contributor

Description

netlink-proto released a new version to downgrade MSRV : rust-netlink/netlink-proto#29 (comment)

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

@AurelienFT AurelienFT requested a review from a team January 27, 2025 09:10
@AurelienFT AurelienFT added the no changelog Skip the CI check of the changelog modification label Jan 27, 2025
@AurelienFT AurelienFT self-assigned this Jan 27, 2025
@AurelienFT AurelienFT requested a review from a team January 28, 2025 09:25
rymnc
rymnc approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AurelienFT AurelienFT enabled auto-merge (squash) January 28, 2025 09:58
@AurelienFT AurelienFT merged commit 9378046 into master Jan 28, 2025
30 checks passed
@AurelienFT AurelienFT deleted the unfix_netlink_proto branch January 28, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgreenx xgreenx xgreenx approved these changes

@rymnc rymnc rymnc approved these changes

@Dentosal Dentosal Awaiting requested review from Dentosal Dentosal is a code owner

@MitchTurner MitchTurner Awaiting requested review from MitchTurner MitchTurner is a code owner

Assignees

@AurelienFT AurelienFT

Labels
no changelog Skip the CI check of the changelog modification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AurelienFT @xgreenx @rymnc