Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Bump rand and flate2 #1923

Merged
merged 2 commits into from
Jul 2, 2019
Merged

build: Bump rand and flate2 #1923

merged 2 commits into from
Jul 2, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Jun 29, 2019

No description provided.

kinnison
kinnison reviewed Jun 30, 2019
View reviewed changes
Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first glance I don't think this will cause issues. The flate2 upgrade is trivial, the rand upgrade, while a new major version (0.6 to 0.7) looks compatible enough.

Does this reduce the complexity of our dependency tree at all?

@kinnison
Copy link
Contributor

I'm holding off on approving until we fix the spurious failures and then rebase.

@tesuji tesuji force-pushed the rand-up branch 2 times, most recently from 474e786 to 73bd472 Compare June 30, 2019 18:33
@tesuji
build: Bump other deps
43f36a5 
    Updating backtrace v0.3.30 -> v0.3.32
    Updating backtrace-sys v0.1.28 -> v0.1.30
    Updating chrono v0.4.6 -> v0.4.7
    Updating curl-sys v0.4.18 -> v0.4.19
    Updating digest v0.8.0 -> v0.8.1
    Updating futures v0.1.27 -> v0.1.28
    Updating flate2 v0.1.7 -> v0.1.9
    Updating generic-array v0.12.0 -> v0.12.3
    Updating getrandom v0.1.5 -> v0.1.6
    Updating h2 v0.1.23 -> v0.1.25
    Updating hyper v0.12.30 -> v0.12.31
    Updating ryu v0.2.8 -> v1.0.0
    Updating serde v1.0.92 -> v1.0.94
    Updating serde_derive v1.0.92 -> v1.0.94
    Updating serde_json v1.0.39 -> v1.0.40
    Updating string v0.2.0 -> v0.2.1
    Updating syn v0.15.36 -> v0.15.39
    Updating tempfile v3.0.8 -> v3.0.9
    Updating vcpkg v0.2.6 -> v0.2.7
    Updating want v0.0.6 -> v0.2.0
@kinnison kinnison merged commit f44c63a into rust-lang:master Jul 2, 2019
This was referenced Jul 2, 2019
Merged
Merged
Merged
@tesuji tesuji deleted the rand-up branch July 2, 2019 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinnison kinnison kinnison left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tesuji @kinnison