build: Transform most CI scripts to bash #1916
Conversation
|
I'm prepared to entertain merging this (being explicit about |
|
☔ The latest upstream changes (presumably #1923) made this pull request unmergeable. Please resolve the merge conflicts. |
tesuji
force-pushed
the
ci-bash
branch
3 times, most recently
from
65c8c51 to
926b56d
Compare
|
☔ The latest upstream changes (presumably #1955) made this pull request unmergeable. Please resolve the merge conflicts. |
tesuji
force-pushed
the
ci-bash
branch
3 times, most recently
from
abd79e6 to
a577f72
Compare
It looks like we cannot fix it anytime soon. |
|
I do not want clippy on stable -- I value strongly the indication that beta isn't regressing (and right now it is) and I can deal with deciding if the failure is relevant. |
|
In that case: Do you want to keep clippy on beta or move it to nightly? |
|
Definitely keep it on beta -- it gives us an excellent canary for whether or not there might be issues in the next stable. |
By combining multiple ENV keys, we could reduce intermediate layer that docker processes, hence the time it takes to build new docker images reduced.
|
I dropped the clippy commit. |
We only use those scripts in CI where bash is always the default shell.
Bash provide modern features and more convenient scripting experience
(i.e. may reduced error rate) with almost no penalty other than portability
and unnoticeable run time. But that's acceptable for our CI.