feat: Add enums exercises #224
Conversation
nyxtom
force-pushed
the
feat-enums
branch
3 times, most recently
from
9ca2030 to
a60d34e
Compare
There was a problem hiding this comment.
Fundamentally it's a good idea, but I don't think having IP address kind as a reference enum is a good idea, since not all people might be familiar with it. Why not go for the Coin example for all exercises?
Also, I noticed there's two enums PRs now, so I'll cc @xmaayy on this just to be sure. If the feedback here gets addressed and there's nothing else, I'll merge this one since the other one doesn't seem to be active.
|
☔ The latest upstream changes (presumably #219) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I’ll go ahead and update the exercises. Though the book itself uses ipaddr and ipkind as a point of interest (this is mainly what I followed here). Note the use of IpAddr/IpKind here https://doc.rust-lang.org/book/ch06-01-defining-an-enum.html |
|
@fmoko I ended up just simplifying the implementations to just stick with the |
|
Does @bors need to rerun to remove the label |
shadows-withal
removed
the
S-waiting-on-author
|
Merging this now. @bors: r+ |
|
📌 Commit dc15032 has been approved by |
feat: Add enums exercises Creates an exhaustive list of enum exercises. This goes through the basics of different ways to derive enums with mixed data type variants, as well as the use of the all important `match` operator.
|
☀️ Test successful - checks-travis |
feat: Add enums exercises Creates an exhaustive list of enum exercises. This goes through the basics of different ways to derive enums with mixed data type variants, as well as the use of the all important `match` operator.
feat: Add enums exercises Creates an exhaustive list of enum exercises. This goes through the basics of different ways to derive enums with mixed data type variants, as well as the use of the all important `match` operator.
Creates an exhaustive list of enum exercises. This goes through the basics of different ways to derive enums with mixed data type variants, as well as the use of the all important
matchoperator.