Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MSRV #4554

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Fix MSRV #4554

merged 1 commit into from
Nov 27, 2020

Conversation

chansuke
Copy link
Contributor

Fixes #4537.

calebcartwright
calebcartwright approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@calebcartwright calebcartwright merged commit 6eba511 into rust-lang:master Nov 27, 2020
davidalber added a commit to davidalber/rustfmt-travis that referenced this pull request Dec 24, 2020
@davidalber
Fix remote Travis config extraction
bb52194 
The remote Travis config extraction searches the rustfmt README
for the line above the Travis config. That line was modified in
rust-lang/rustfmt#4554. This commit incorporates that change into
the config extraction logic.
davidalber added a commit to davidalber/rustfmt-travis that referenced this pull request May 31, 2021
@davidalber
Update local config and matching logic
a641545 
I'm not sure why I am needing to do this. It looks like the
rust-lang/rustfmt README.md file was force pushed to an older
revision. For instance, the minimum Rust version was updated to
1.31 in rust-lang/rustfmt#4554, but that commit
(rust-lang/rustfmt@769fe94) is no longer on the rust-lang/rustfmt
`master` branch. The latest commit on the README.md file in that
repository is now rust-lang/rustfmt@dfd276, which was committed on
Aug 15, 2019.
@karyon karyon mentioned this pull request Oct 28, 2021
Merged
@karyon karyon added 1x-backport:pending Fixed/resolved in source but not yet backported to a 1x branch and release and removed backport-triage labels Oct 28, 2021
@ytmimi
Copy link
Contributor

ytmimi commented Mar 29, 2022

The backport was completed by #5048

@ytmimi ytmimi added 1x-backport:completed and removed 1x-backport:pending Fixed/resolved in source but not yet backported to a 1x branch and release labels Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
1x-backport:completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong MSRV in README
4 participants
@chansuke @ytmimi @calebcartwright @karyon