Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong MSRV in README #4537

Closed
YaLTeR opened this issue Nov 20, 2020 · 2 comments · Fixed by #4554
Closed

Wrong MSRV in README #4537

YaLTeR opened this issue Nov 20, 2020 · 2 comments · Fixed by #4554
Labels
documentation good first issue Issues up for grabs, also good candidates for new rustfmt contributors help wanted

Comments

@YaLTeR
Copy link
Contributor

YaLTeR commented Nov 20, 2020

A minimal Travis setup could look like this (requires Rust 1.24.0 or greater):

However, the rustfmt component is only available starting from 1.31.0. Anything below gives:

└─ rustup toolchain add 1.30.0 -c rustfmt
info: syncing channel updates for '1.30.0-x86_64-unknown-linux-gnu'
info: latest update on 2018-10-25, rust version 1.30.0 (da5f414c2 2018-10-24)
error: component 'rustfmt' for target 'x86_64-unknown-linux-gnu' is unavailable for download for channel 1.30.0
@YaLTeR YaLTeR added the bug Panic, non-idempotency, invalid code, etc. label Nov 20, 2020
@calebcartwright calebcartwright added documentation and removed bug Panic, non-idempotency, invalid code, etc. labels Nov 21, 2020
@calebcartwright
Copy link
Member

The docs originally mentioned the rustfmt-preview component which was subsequently corrected (as that component stopped being shipped a long time ago), but obviously the version wasn't updated accordingly.

Thanks for the report @YaLTeR!

For anyone interested in fixing this, the incorrect line can be found here:
https://github.com/rust-lang/rustfmt#checking-style-on-a-ci-server

@calebcartwright calebcartwright added good first issue Issues up for grabs, also good candidates for new rustfmt contributors help wanted labels Nov 21, 2020
@chansuke
Copy link
Contributor

I'd like to fix this.

@chansuke chansuke mentioned this issue Nov 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation good first issue Issues up for grabs, also good candidates for new rustfmt contributors help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix MSRV chansuke/rustfmt
3 participants
@chansuke @YaLTeR @calebcartwright