Rollup of 10 pull requests #90934
Merged
Rollup of 10 pull requests #90934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Konrad Borowski <konrad@borowski.pw>
Renames File::with_options to File::options, per consensus in rust-lang#65439, and stabilizes it.
Rename WASI's `FileTypeExt::is_character_device` to `FileTypeExt::is_char_device`, for consistency with the Unix `FileTypeExt::is_char_device`. Also, add a `FileTypeExt::is_socket` function, for consistency with the Unix `FileTypeExt::is_socket` function.
These are working well for *unsigned* types, for the the signed ones there are a bunch of questions about what the semantics and API should be. And for the main "helpers for big integer implementations" use, there's no need for the signed versions anyway. And there are plenty of other methods which exist for unsigned types but not signed ones, like `next_power_of_two`, so this isn't unusual. Fixes 90541
Tweak the `options!` macro to allow for -Z and -C options with the same name without generating conflicting internal parsing functions. Split out of the commit stabilizing -Z strip as -C strip.
Leave -Z strip available temporarily as an alias, to avoid breaking cargo until cargo transitions to using -C strip. (If the user passes both, the -C version wins.)
Stabilize File::options() Renames File::with_options to File::options, per consensus in rust-lang#65439, and stabilizes it.
…llible, r=yaahc Implement `Termination` for `Result<Infallible, E>` As noted in rust-lang#43301, `Result<!, E>` is not usable on stable.
…leywiser Stabilize -Z strip as -C strip Leave -Z strip available temporarily as an alias, to avoid breaking cargo until cargo transitions to using -C strip.
…-Simulacrum Fix standard library test with read_link closes rust-lang#90669 resolve this issue by comparing between Paths instead of strs
Android is not GNU For a long time, the Android targets had `target_env=""`, but this changed to `"gnu"` in Rust 1.49.0. I tracked this down to rust-lang#77729 which started setting `"gnu"` in the `linux_base` target options, and this was inherited by `android_base`. Then rust-lang#78929 split the env into `linux_gnu_base`, but `android_base` was also changed to follow that. Android was not specifically mentioned in either pull request, so I believe this was an accident. Moving it back to `linux_base` will use an empty `env` again. r? ````@Mark-Simulacrum```` cc ````@petrochenkov````
…evice, r=alexcrichton Rename WASI's `is_character_device` to `is_char_device`. Rename WASI's `FileTypeExt::is_character_device` to `FileTypeExt::is_char_device`, for consistency with the Unix `FileTypeExt::is_char_device`. Also, add a `FileTypeExt::is_socket` function, for consistency with the Unix `FileTypeExt::is_socket` function. r? `@alexcrichton`
Move some tests to more reasonable directories - 9 cc rust-lang#73494 r? `@petrochenkov`
…rs, r=joshtriplett Remove bigint_helper_methods for *signed* types This PR inspired by `@cuviper's` comment @ rust-lang#90541 (comment) These are working well for *unsigned* types, so keep those, but for the the *signed* ones there are a bunch of questions about what the semantics and API should be. For the main "helpers for big integer implementations" use, there's no need for the signed versions anyway. There are plenty of other methods which exist for unsigned types but not signed ones, like `next_power_of_two`, so this isn't unusual. Fixes rust-lang#90541 Tracking issue rust-lang#85532
…li-obk fix ICE on Miri/CTFE copy of half a pointer Fixes rust-lang/miri#1910 r? `````@oli-obk`````
…orkingjubilee disable portable SIMD tests in Miri Until rust-lang/miri#1912 is resolved, we'll have to skip these tests in Miri.
|
@bors r+ rollup=never p=10 |
|
📌 Commit 35dd1f6 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Nov 16, 2021
|
Finished benchmarking commit (0206312): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
TerminationforResult<Infallible, E>#88601 (ImplementTerminationforResult<Infallible, E>)is_character_devicetois_char_device. #90835 (Rename WASI'sis_character_devicetois_char_device.)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup