Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable portable SIMD tests in Miri #90909

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

RalfJung
Copy link
Member

Until rust-lang/miri#1912 is resolved, we'll have to skip these tests in Miri.

@rust-highfive
Copy link
Collaborator

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 14, 2021
bors added a commit to rust-lang/miri that referenced this pull request Nov 14, 2021
run rustdoc with the miri cfg flag

This is important to be able to control which doctests run with `cargo miri test`. In particular, this is required for rust-lang/rust#90909 to work as intended.
@workingjubilee
Copy link
Member

Sorry for breaking Miri! ^^;
At least that was the only catastrophe.
@bors r+

@bors
Copy link
Contributor

bors commented Nov 15, 2021

📌 Commit 60595f7 has been approved by workingjubilee

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 15, 2021
@RalfJung
Copy link
Member Author

You only broke https://github.com/rust-lang/miri-test-libstd, so it's really not a problem. :)

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Nov 15, 2021
…orkingjubilee

disable portable SIMD tests in Miri

Until rust-lang/miri#1912 is resolved, we'll have to skip these tests in Miri.
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Nov 15, 2021
…orkingjubilee

disable portable SIMD tests in Miri

Until rust-lang/miri#1912 is resolved, we'll have to skip these tests in Miri.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 15, 2021
…orkingjubilee

disable portable SIMD tests in Miri

Until rust-lang/miri#1912 is resolved, we'll have to skip these tests in Miri.
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 16, 2021
Rollup of 10 pull requests

Successful merges:

 - rust-lang#85766 (Stabilize File::options())
 - rust-lang#88601 (Implement `Termination` for `Result<Infallible, E>`)
 - rust-lang#90058 (Stabilize -Z strip as -C strip)
 - rust-lang#90790 (Fix standard library test with read_link)
 - rust-lang#90834 (Android is not GNU)
 - rust-lang#90835 (Rename WASI's `is_character_device` to `is_char_device`.)
 - rust-lang#90837 (Move some tests to more reasonable directories - 9)
 - rust-lang#90848 (Remove bigint_helper_methods for *signed* types)
 - rust-lang#90892 (fix ICE on Miri/CTFE copy of half a pointer)
 - rust-lang#90909 (disable portable SIMD tests in Miri)

Failed merges:

 - rust-lang#90128 (Stabilize -Z symbol-mangling-version=v0 as -C symbol-mangling-version=v0)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 35dd1f6 into rust-lang:master Nov 16, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 16, 2021
@RalfJung RalfJung deleted the miri-no-portable-simd branch November 16, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants