Rollup of 7 pull requests #89731

matthiaskrgr · 2021-10-10T08:33:28Z

Successful merges:

Improve docs for int_log #88713 (Improve docs for int_log)
Feature gate the non_exhaustive_omitted_patterns lint #89428 (Feature gate the non_exhaustive_omitted_patterns lint)
Don't rebuild GUI test crates every time you run test src/test/rustdoc-gui #89520 (Don't rebuild GUI test crates every time you run test src/test/rustdoc-gui)
Cfg hide no_global_oom_handling and no_fp_fmt_parse #89705 (Cfg hide no_global_oom_handling and no_fp_fmt_parse)
Add #[must_use] to is_condition tests #89718 (Add #[must_use] to is_condition tests)
Add #[must_use] to char escape methods #89719 (Add #[must_use] to char escape methods)
Add #[must_use] to math and bit manipulation methods #89720 (Add #[must_use] to math and bit manipulation methods)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

* Clarify rounding. * Avoid "wrapping" wording. * Omit wrong claim on 0 only being returned in error cases. * Typo fix for one_less_than_next_power_of_two.

…c-gui

Actually add the feature to the lints ui test Add tracking issue to the feature declaration Rename feature gate to non_exhaustive_omitted_patterns_lint Add more omitted_patterns lint feature gate

There's nothing insightful to say about these so I didn't write any extra explanations.

Also tidied up a few other nearby `#[must_use]`s.

…on-fixes, r=scottmcm Improve docs for int_log * Clarify rounding. * Avoid "wrapping" wording. * Omit wrong claim on 0 only being returned in error cases. * Typo fix for one_less_than_next_power_of_two.

…Nadrieril,camelid Feature gate the non_exhaustive_omitted_patterns lint Fixes rust-lang#89374 Add the machinery to gate the new `non_exhaustive_omitted_patterns` lint. relates to rust-lang#89105 and rust-lang#89423

…st, r=Mark-Simulacrum Don't rebuild GUI test crates every time you run test src/test/rustdoc-gui This method has multiple advantages: * It'll completely remove the rustdoc-GUI test doc folder if rustdoc was updated * It'll rebuild GUI test crates only they have been updated All in all, it's quite convenient! (even more with rust-lang#88816) r? ``@Mark-Simulacrum``

Cfg hide no_global_oom_handling and no_fp_fmt_parse These are unstable sysroot customisation cfg options that only projects building their own sysroot will use (e.g. Rust-for-linux). Most users shouldn't care. `no_global_oom_handling` can be especially annoying since it's applied on many commonly used alloc crate methods (e.g. `Box::new`, `Vec::push`). r? ``@GuillaumeGomez``

…ts, r=joshtriplett Add #[must_use] to is_condition tests There's nothing insightful to say about these so I didn't write any extra explanations. Parent issue: rust-lang#89692

…ods, r=joshtriplett Add #[must_use] to char escape methods Parent issue: rust-lang#89692

… r=joshtriplett Add #[must_use] to math and bit manipulation methods Also tidied up a few other nearby `#[must_use]`s. Parent issue: rust-lang#89692

matthiaskrgr · 2021-10-10T08:34:25Z

@bors r+ p=7

bors · 2021-10-10T08:34:27Z

📌 Commit f34b849 has been approved by matthiaskrgr

bors · 2021-10-10T11:28:50Z

⌛ Testing commit f34b849 with merge d253864c236c8c3f77036b576b8fa501e8c874e7...

bors · 2021-10-10T12:29:42Z

💔 Test failed - checks-actions

rust-log-analyzer · 2021-10-10T12:30:27Z

The job dist-x86_64-apple failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

      Memory: 14 GB
      Boot ROM Version: VMW71.00V.13989454.B64.1906190538
      Apple ROM Info: [MS_VM_CERT/SHA1/27d66596a61c48dd3dc7216fd715126e33f59ae7]Welcome to the Virtual Machine
      SMC Version (system): 2.8f0
      Serial Number (system): VMbWJDsMqNFW

hw.ncpu: 3
hw.byteorder: 1234
hw.memsize: 15032385536
---
[ 20%] Built target RTLSanCommon.osx
[ 40%] Built target RTSanitizerCommonSymbolizer.osx
Consolidate compiler generated dependencies of target RTSanitizerCommonLibc.osx
Consolidate compiler generated dependencies of target RTInterception.osx
lib/sanitizer_common/CMakeFiles/RTSanitizerCommon.osx.dir/compiler_depend.make:1061: *** multiple target patterns.  Stop.
Consolidate compiler generated dependencies of target RTSanitizerCommon.osx
[ 50%] Built target RTInterception.osx
[ 50%] Built target RTInterception.osx
make[2]: *** [lib/sanitizer_common/CMakeFiles/RTSanitizerCommon.osx.dir/all] Error 2
make[2]: *** Waiting for unfinished jobs....
 finished in 77.127 seconds
make[1]: *** [lib/lsan/CMakeFiles/clang_rt.lsan_osx_dynamic.dir/rule] Error 2
Build completed unsuccessfully in 0:43:47
make: *** [clang_rt.lsan_osx_dynamic] Error 2
command did not execute successfully, got: exit status: 2


build script failed, must exit now', /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/cmake-0.1.44/src/lib.rs:885:5

matthiaskrgr · 2021-10-10T13:07:59Z

looks spurious to me, none of the changes look like they change sanitizer code
@bors retry

bors · 2021-10-10T15:14:14Z

⌛ Testing commit f34b849 with merge 5322356f328d8e5ad5983115d534f59bba733dc5...

rust-log-analyzer · 2021-10-10T15:58:45Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

..        (43/43)


search-result-display... FAILED
[ERROR] (line 5) TimeoutError: waiting for selector "#titles" failed: timeout 30000ms exceeded: for command `wait-for: "#titles"`



command did not execute successfully: "/node-v14.4.0-linux-x64/bin/node" "/checkout/src/tools/rustdoc-gui/tester.js" "--jobs" "16" "--doc-folder" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc" "--tests-folder" "/checkout/src/test/rustdoc-gui"


Build completed unsuccessfully in 0:00:44

bors · 2021-10-10T15:59:22Z

💔 Test failed - checks-actions

matthiaskrgr · 2021-10-10T16:20:15Z

Timeout in rustdoc tests

     Finished release [optimized] target(s) in 0.23s
[TIMING] Rustdoc { compiler: Compiler { stage: 2, host: TargetSelection { triple: "x86_64-unknown-linux-gnu", file: None } } } -- 0.249
 Documenting link_to_definition v0.1.0 (/checkout/src/test/rustdoc-gui/src/link_to_definition)
    Finished dev [unoptimized + debuginfo] target(s) in 1.09s
 Documenting implementors v0.1.0 (/checkout/src/test/rustdoc-gui/src/lib2/implementors)
    Checking implementors v0.1.0 (/checkout/src/test/rustdoc-gui/src/lib2/implementors)
 Documenting lib2 v0.1.0 (/checkout/src/test/rustdoc-gui/src/lib2)
    Finished dev [unoptimized + debuginfo] target(s) in 1.93s
   Compiling test_docs v0.1.0 (/checkout/src/test/rustdoc-gui/src/test_docs)
 Documenting test_docs v0.1.0 (/checkout/src/test/rustdoc-gui/src/test_docs)
    Finished dev [unoptimized + debuginfo] target(s) in 2.50s
 Documenting settings v0.1.0 (/checkout/src/test/rustdoc-gui/src/settings)
    Finished dev [unoptimized + debuginfo] target(s) in 0.96s
Running 43 rustdoc-gui (16 concurrently) ...
.......... (10/43)
.......... (20/43)
.......... (30/43)
.......... (40/43)
..        (43/43)


search-result-display... FAILED
Error:  (line 5) TimeoutError: waiting for selector "#titles" failed: timeout 30000ms exceeded: for command `wait-for: "#titles"`

Falk Hüffner and others added 14 commits September 7, 2021 08:53

Improve docs for int_log

138ebd1

* Clarify rounding. * Avoid "wrapping" wording. * Omit wrong claim on 0 only being returned in error cases. * Typo fix for one_less_than_next_power_of_two.

Don't rebuild GUI test crates every time you run test src/test/rustdo…

d26e192

…c-gui

Add feature gate to non_exhaustive_omitted_patterns lint

1433878

Actually add the feature to the lints ui test Add tracking issue to the feature declaration Rename feature gate to non_exhaustive_omitted_patterns_lint Add more omitted_patterns lint feature gate

Cfg hide no_global_oom_handling and no_fp_fmt_parse

0182566

Add #[must_use] to is_condition tests

475e992

There's nothing insightful to say about these so I didn't write any extra explanations.

Add #[must_use] to char escape methods

fec9514

Add #[must_use] to math and bit manipulation methods

bc9d13e

Also tidied up a few other nearby `#[must_use]`s.

Rollup merge of rust-lang#88713 - falk-hueffner:int-log10-documentati…

e5ea3f2

…on-fixes, r=scottmcm Improve docs for int_log * Clarify rounding. * Avoid "wrapping" wording. * Omit wrong claim on 0 only being returned in error cases. * Typo fix for one_less_than_next_power_of_two.

Rollup merge of rust-lang#89718 - jkugelman:must-use-is_condition-tes…

3accc71

…ts, r=joshtriplett Add #[must_use] to is_condition tests There's nothing insightful to say about these so I didn't write any extra explanations. Parent issue: rust-lang#89692

Rollup merge of rust-lang#89719 - jkugelman:must-use-char-escape-meth…

98c5279

…ods, r=joshtriplett Add #[must_use] to char escape methods Parent issue: rust-lang#89692

Rollup merge of rust-lang#89720 - jkugelman:must-use-math-operations,…

f34b849

… r=joshtriplett Add #[must_use] to math and bit manipulation methods Also tidied up a few other nearby `#[must_use]`s. Parent issue: rust-lang#89692

rustbot added the rollup A PR which is a rollup label Oct 10, 2021

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 10, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 10, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 10, 2021

matthiaskrgr closed this Oct 10, 2021

matthiaskrgr deleted the rollup-3builwl branch November 20, 2021 15:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 7 pull requests #89731

Rollup of 7 pull requests #89731

matthiaskrgr commented Oct 10, 2021

matthiaskrgr commented Oct 10, 2021

bors commented Oct 10, 2021

bors commented Oct 10, 2021

bors commented Oct 10, 2021

rust-log-analyzer commented Oct 10, 2021

matthiaskrgr commented Oct 10, 2021

bors commented Oct 10, 2021

rust-log-analyzer commented Oct 10, 2021

bors commented Oct 10, 2021

matthiaskrgr commented Oct 10, 2021

Rollup of 7 pull requests #89731

Rollup of 7 pull requests #89731

Conversation

matthiaskrgr commented Oct 10, 2021

matthiaskrgr commented Oct 10, 2021

bors commented Oct 10, 2021

bors commented Oct 10, 2021

bors commented Oct 10, 2021

rust-log-analyzer commented Oct 10, 2021

matthiaskrgr commented Oct 10, 2021

bors commented Oct 10, 2021

rust-log-analyzer commented Oct 10, 2021

bors commented Oct 10, 2021

matthiaskrgr commented Oct 10, 2021