Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature flag for type_changing_struct_update #89730

Merged
merged 1 commit into from
Oct 23, 2021

Conversation

crlf0710
Copy link
Member

This implements the PR0 part of the mentoring notes within #86618.

overrides the previous inactive #86646 pr.

r? @nikomatsakis

@crlf0710 crlf0710 added the F-type-changing-struct-update `#![feature(type_changing_struct_update)]` label Oct 10, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 10, 2021
@crlf0710 crlf0710 force-pushed the type_changing_feature branch 2 times, most recently from 6c49959 to 6721482 Compare October 10, 2021 06:59
@rust-log-analyzer

This comment has been minimized.

@bors

This comment has been minimized.

@crlf0710 crlf0710 force-pushed the type_changing_feature branch 2 times, most recently from 3bc6ad7 to a14e3fb Compare October 11, 2021 06:21
@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 14, 2021
@crlf0710 crlf0710 added the T-lang Relevant to the language team, which will review and decide on the PR/issue. label Oct 14, 2021
@jackh726
Copy link
Member

I'll get this moving. r? @jackh726

Ping #90035, which does basically the same thing, but with some more tests and such. (We can land this first, and then rebase that on this)

@jackh726
Copy link
Member

r=me with tracking issue changed

@jackh726
Copy link
Member

I've updated the tracking issue and version, but otherwise done nothing.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 22, 2021

📌 Commit 7d7ebf8 has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 22, 2021
…ackh726

add feature flag for `type_changing_struct_update`

This implements the PR0 part of the mentoring notes within rust-lang#86618.

overrides the previous inactive rust-lang#86646 pr.

r? `@nikomatsakis`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 22, 2021
…ackh726

add feature flag for `type_changing_struct_update`

This implements the PR0 part of the mentoring notes within rust-lang#86618.

overrides the previous inactive rust-lang#86646 pr.

r? ``@nikomatsakis``
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 23, 2021
…askrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#83233 (Implement split_array and split_array_mut)
 - rust-lang#88300 (Stabilise unix_process_wait_more, extra ExitStatusExt methods)
 - rust-lang#89416 (nice_region_error: Include lifetime placeholders in error output)
 - rust-lang#89468 (Report fatal lexer errors in `--cfg` command line arguments)
 - rust-lang#89730 (add feature flag for `type_changing_struct_update`)
 - rust-lang#89920 (Implement -Z location-detail flag)
 - rust-lang#90070 (Add edition configuration to compiletest)
 - rust-lang#90087 (Sync rustfmt subtree)
 - rust-lang#90117 (Make RSplit<T, P>: Clone not require T: Clone)
 - rust-lang#90122 (CI: make docker cache download and `docker load` time out after 10 minutes)
 - rust-lang#90166 (Add comment documenting why we can't use a simpler solution)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 736e8eb into rust-lang:master Oct 23, 2021
@rustbot rustbot added this to the 1.58.0 milestone Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-type-changing-struct-update `#![feature(type_changing_struct_update)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants