Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unstable deprecated Vec::remove_item #80972

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Remove unstable deprecated Vec::remove_item #80972

merged 1 commit into from
Jan 14, 2021

Conversation

KodrAus
Copy link
Contributor

@KodrAus KodrAus commented Jan 13, 2021

Closes #40062

The Vec::remove_item method was deprecated in 1.46.0 (in August of 2020). This PR now removes that unstable method entirely.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 13, 2021
@nagisa
Copy link
Member

nagisa commented Jan 13, 2021

Seems reasonable enough.

@bors r+

@bors
Copy link
Contributor

bors commented Jan 13, 2021

📌 Commit 7e83fec has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 13, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 14, 2021
…gisa

Remove unstable deprecated Vec::remove_item

Closes rust-lang#40062

The `Vec::remove_item` method was deprecated in `1.46.0` (in August of 2020). This PR now removes that unstable method entirely.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 14, 2021
…gisa

Remove unstable deprecated Vec::remove_item

Closes rust-lang#40062

The `Vec::remove_item` method was deprecated in `1.46.0` (in August of 2020). This PR now removes that unstable method entirely.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 14, 2021
…gisa

Remove unstable deprecated Vec::remove_item

Closes rust-lang#40062

The `Vec::remove_item` method was deprecated in `1.46.0` (in August of 2020). This PR now removes that unstable method entirely.
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Jan 14, 2021
…gisa

Remove unstable deprecated Vec::remove_item

Closes rust-lang#40062

The `Vec::remove_item` method was deprecated in `1.46.0` (in August of 2020). This PR now removes that unstable method entirely.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 14, 2021
Rollup of 17 pull requests

Successful merges:

 - rust-lang#79982 (Add missing methods to unix ExitStatusExt)
 - rust-lang#80017 (Suggest `_` and `..` if a pattern has too few fields)
 - rust-lang#80169 (Recommend panic::resume_unwind instead of panicking.)
 - rust-lang#80217 (Add a `std::io::read_to_string` function)
 - rust-lang#80444 (Add as_ref and as_mut methods for Bound)
 - rust-lang#80567 (Add Iterator::intersperse_with)
 - rust-lang#80829 (Get rid of `DepConstructor`)
 - rust-lang#80895 (Fix handling of malicious Readers in read_to_end)
 - rust-lang#80966 (Deprecate atomic::spin_loop_hint in favour of hint::spin_loop)
 - rust-lang#80969 (Use better ICE message when no MIR is available)
 - rust-lang#80972 (Remove unstable deprecated Vec::remove_item)
 - rust-lang#80973 (Update books)
 - rust-lang#80980 (Fixed incorrect doc comment)
 - rust-lang#80981 (Fix -Cpasses=list and llvm version print with -vV)
 - rust-lang#80985 (Fix stabilisation version of slice_strip)
 - rust-lang#80990 (llvm: Remove the unused context from CreateDebugLocation)
 - rust-lang#80991 (Fix formatting specifiers doc links)

Failed merges:

 - rust-lang#80944 (Use Option::map_or instead of `.map(..).unwrap_or(..)`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9bfe6f1 into rust-lang:master Jan 14, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 14, 2021
bors bot added a commit to gfx-rs/wgpu-rs that referenced this pull request Apr 13, 2021
855: Remove comment about `Vec::remove_item` r=kvark a=Pat-Lafon

Sadly, `Vec::remove_item` was an unstable method that was deprecated and has now been removed.

rust-lang/rust#80972

This pr removes a comment suggesting to use `Vec::remove_item` when it stabilizes.

Co-authored-by: Patrick LaFontaine <32135464+Pat-Lafon@users.noreply.github.com>
kvark pushed a commit to kvark/wgpu that referenced this pull request Jun 3, 2021
855: Remove comment about `Vec::remove_item` r=kvark a=Pat-Lafon

Sadly, `Vec::remove_item` was an unstable method that was deprecated and has now been removed.

rust-lang/rust#80972

This pr removes a comment suggesting to use `Vec::remove_item` when it stabilizes.

Co-authored-by: Patrick LaFontaine <32135464+Pat-Lafon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking issue for Vec::remove_item
6 participants