Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multi-layer copies #855

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Fix multi-layer copies #855

merged 1 commit into from
Jul 30, 2020

Conversation

cwfitzgerald
Copy link
Member

Description

When copying multiple layers at the same time, we ignored

Testing

Tested on the skybox example with BC1 textures doing all layer copies.

@cwfitzgerald cwfitzgerald requested a review from kvark July 30, 2020 21:02
monocodus[bot]
monocodus bot suggested changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@monocodus monocodus bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an autogenerated code review.

Checker summary (by rust_clippy):
The tool has found 0 warnings, 2 errors.

kvark
kvark approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
bors r+

@bors
Copy link
Contributor

bors bot commented Jul 30, 2020

Build succeeded:

@bors bors bot merged commit b352093 into gfx-rs:master Jul 30, 2020
@cwfitzgerald cwfitzgerald deleted the multi-layer-copy-fix branch July 30, 2020 21:50
kvark pushed a commit to kvark/wgpu that referenced this pull request Jun 3, 2021
@bors @Pat-Lafon
[rs] Merge gfx-rs#855
2d5647f 
855: Remove comment about `Vec::remove_item` r=kvark a=Pat-Lafon

Sadly, `Vec::remove_item` was an unstable method that was deprecated and has now been removed.

rust-lang/rust#80972

This pr removes a comment suggesting to use `Vec::remove_item` when it stabilizes.

Co-authored-by: Patrick LaFontaine <32135464+Pat-Lafon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monocodus monocodus monocodus requested changes

@kvark kvark kvark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwfitzgerald @kvark