-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only copy LLVM into rust-dev with internal LLVM #76573
Only copy LLVM into rust-dev with internal LLVM #76573
Conversation
does it make sens to even build it for external llvm ? the tarball will be almost empty. But maybe it will be extended later ? LlvmTools uses the following: /* run only if llvm-config isn't used */
if let Some(config) = builder.config.target_config.get(&target) {
if let Some(ref _s) = config.llvm_config {
builder.info(&format!("Skipping LlvmTools ({}): external LLVM", target));
return None;
}
} |
This avoids needing to figure out where to locate each of the components with an external LLVM.
dbaf8e3
to
4f2d941
Compare
Yeah, I am thinking that we'll expand it eventually but for now I think it does indeed make sense to just skip it entirely. |
Hm I don't think I've kept up enough with this over the past, I'm not sure what |
It's the component intended for aiding rustc development, specifically providing pre-compiled LLVMs to developers (along with llvm-config and header files, basically enough for librustc_llvm to compile and link to this LLVM). It was just added a few days ago in #76332 |
@bors: r+ Ok cool, makes sense to me! |
📌 Commit 4f2d941 has been approved by |
☀️ Test successful - checks-actions, checks-azure |
This avoids needing to figure out where to locate each of the components with an
external LLVM. This component isn't manifested for rustup consumption and
generally shouldn't matter for anyone except Rust's CI, so it is fine for it to not be
complete elsewhere.
Fixes #76572.
r? @alexcrichton